Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(draw): expose extension points #1585

Merged
merged 1 commit into from
Feb 9, 2022
Merged

chore(draw): expose extension points #1585

merged 1 commit into from
Feb 9, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Jan 25, 2022

  • clearly documented as UNSAFE
  • add test cases
  • tested existing UNSAFE handler endpoint

@nikku
chore(draw): expose extension points
e4df2e8 
+ clearly documented as *UNSAFE*
+ add test cases
+ tested existing *UNSAFE* handler endpoint
@nikku nikku requested review from a team, pinussilvestrus and Skaiir and removed request for a team January 25, 2022 11:39
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 25, 2022
@nikku nikku self-assigned this Feb 3, 2022
@marstamm
Copy link
Contributor

marstamm commented Feb 9, 2022

Could you give a little context on the use-case? I guess it is to get access to the render functions outside of the BpmnRender, correct?

@nikku
Copy link
Member Author

nikku commented Feb 9, 2022

Exactly. The use-case is that I am plugging in my own renderer to do some work, but delegate to the bpmnRenderer for the heavy lifting.

I.e. I want to render a task but add my special icon to it.

@marstamm
Copy link
Contributor

marstamm commented Feb 9, 2022

Makes sense, thanks for clarifying

marstamm
marstamm approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nikku
Copy link
Member Author

nikku commented Feb 9, 2022 •
edited
Loading

The way to do this at the moment is to check internal state (cf. https://github.com/bpmn-io/connectors-modeling-demo/blob/master/connectors-extension/ConnectorTaskRenderer.js#L56).

By having an indirection this becomes easier (still, it remains internal 💀).

@nikku nikku merged commit e0a2b41 into develop Feb 9, 2022
@nikku nikku deleted the unsafe-extension-points branch February 9, 2022 13:55
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstamm marstamm marstamm approved these changes

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus pinussilvestrus was automatically assigned from bpmn-io/modeling-dev

@Skaiir Skaiir Awaiting requested review from Skaiir Skaiir was automatically assigned from bpmn-io/modeling-dev

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @marstamm