Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(importer): import all associated processes #1576

Merged
merged 3 commits into from
Jan 31, 2022
Merged

feat(importer): import all associated processes #1576

merged 3 commits into from
Jan 31, 2022

Conversation

marstamm
Copy link
Contributor

closes #1546

  • When opening a diagram of a subprocess, I want to import all associated diagrams and switch to the plane I requested
  • When the file has multiple overlapping DIs for the same process we are opening, only import one. If none is specified, use the first.

@marstamm marstamm requested review from philippfromme, a team and barmac and removed request for a team January 17, 2022 10:06
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 17, 2022
@marstamm marstamm force-pushed the 1546-rework-viewer-open branch from a3f63b0 to 7ad6ddd Compare January 17, 2022 10:07
@philippfromme philippfromme force-pushed the 1546-rework-viewer-open branch from 7ad6ddd to 3c629b9 Compare January 31, 2022 10:19
philippfromme
philippfromme approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restructured the multi-diagram tests as they were getting a bit confusing.

Good job. 👍🏻

@philippfromme philippfromme merged commit e6c6996 into develop Jan 31, 2022
@philippfromme philippfromme deleted the 1546-rework-viewer-open branch January 31, 2022 10:23
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 31, 2022
@marstamm marstamm mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

@nikku nikku nikku left review comments

@barmac barmac Awaiting requested review from barmac barmac was automatically assigned from bpmn-io/modeling-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure compatibility with single-plane imports
3 participants
@marstamm @nikku @philippfromme