Fix copy paste with ids #1509
Merged
Fix copy paste with ids #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
force-pushed
the
fix-copy-paste
branch
from
5a3af86 to
93008e9
Compare
|
The newly added test case fails when it's run in the test suite. It works fine in an |
barmac
force-pushed
the
fix-copy-paste
branch
from
a7490e8 to
6bd4158
Compare
|
@nikku @philippfromme Ready for review |
nikku
reviewed
Oct 20, 2021
barmac
force-pushed
the
fix-copy-paste
branch
from
6bd4158 to
74683e2
Compare
nikku
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we just blindly copied ID as if it were a primitive value, if the ID wasn't claimed. This PR adds special handling for the IDs. If the ID is taken, we disallow copy. If it's free, we first claim it and then re-use it.
verify.mov
Related to camunda/camunda-modeler#1410