Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect Reverse #1230

Merged
merged 7 commits into from
Nov 18, 2019
Merged

Connect Reverse #1230

merged 7 commits into from
Nov 18, 2019

Conversation

philippfromme
Copy link
Contributor

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 4, 2019
@philippfromme philippfromme force-pushed the 386-connect-reverse branch 3 times, most recently from 653cac9 to 54fdee2 Compare November 6, 2019 12:08
@philippfromme philippfromme marked this pull request as ready for review November 6, 2019 18:26
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 6, 2019
@philippfromme philippfromme requested a review from nikku November 7, 2019 07:24
nikku
nikku requested changes Nov 7, 2019
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Looking at the changes required in bpmn-js, it definitely looks like a breaking change release for me.

lib/features/snapping/BpmnConnectSnapping.js Show resolved Hide resolved
lib/features/modeling/BpmnLayouter.js Show resolved Hide resolved
lib/features/modeling/behavior/ReplaceConnectionBehavior.js Outdated Show resolved Hide resolved
@philippfromme philippfromme force-pushed the 386-connect-reverse branch 2 times, most recently from f45ea05 to 237fc0a Compare November 14, 2019 08:00
@philippfromme philippfromme requested a review from nikku November 14, 2019 08:32
@nikku nikku force-pushed the 386-connect-reverse branch from 237fc0a to a24c16f Compare November 18, 2019 10:50
@nikku
Copy link
Member

nikku commented Nov 18, 2019

Need to document the breaking changes on bpmn-js, too.

nikku
nikku approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 👾

@nikku nikku merged commit 06e1478 into develop Nov 18, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 18, 2019
@fake-join fake-join bot deleted the 386-connect-reverse branch November 18, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @nikku