Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two-Step Pasting #1137

Merged
merged 4 commits into from
Aug 7, 2019
Merged

Two-Step Pasting #1137

merged 4 commits into from
Aug 7, 2019

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jul 30, 2019 •
edited by nikku
Loading

Requires bpmn-io/diagram-js#390
Requires bpmn-io/diagram-js#390

Related to #888
Related to #1138
Related to #1139

Related to camunda/camunda-modeler#1421

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 30, 2019
@philippfromme philippfromme mentioned this pull request Jul 30, 2019
Merged
@philippfromme philippfromme force-pushed the 1421-two-step-pasting branch 2 times, most recently from 0a43f93 to 1f8d7cd Compare August 1, 2019 08:35
@philippfromme philippfromme changed the title WIP Two-Step Pasting Two-Step Pasting Aug 1, 2019
@nikku nikku added needs review Review pending and removed in progress Currently worked on labels Aug 1, 2019 — with bpmn-io-tasks
@nikku nikku added this to the M30 milestone Aug 2, 2019
@philippfromme philippfromme changed the title Two-Step Pasting WIP Two-Step Pasting Aug 2, 2019
@philippfromme philippfromme added in progress Currently worked on and removed needs review Review pending labels Aug 2, 2019 — with bpmn-io-tasks
@philippfromme philippfromme changed the title WIP Two-Step Pasting Two-Step Pasting Aug 2, 2019
@philippfromme
Copy link
Contributor Author

Ready to be reviewed.

@philippfromme philippfromme added needs review Review pending and removed in progress Currently worked on labels Aug 2, 2019 — with bpmn-io-tasks
nikku
nikku reviewed Aug 2, 2019
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of good changes in da 👜 👍.

lib/features/modeling/ElementFactory.js Show resolved Hide resolved
lib/features/copy-paste/BpmnCopyPaste.js Outdated Show resolved Hide resolved
lib/features/rules/BpmnRules.js Outdated Show resolved Hide resolved
lib/features/copy-paste/BpmnCopyPaste.js Outdated Show resolved Hide resolved
lib/features/modeling/behavior/CopyPasteBehavior.js Show resolved Hide resolved
@philippfromme philippfromme mentioned this pull request Aug 2, 2019
Closed
@philippfromme philippfromme force-pushed the 1421-two-step-pasting branch 2 times, most recently from 2f60014 to 07adb8a Compare August 4, 2019 11:31
@philippfromme philippfromme added in progress Currently worked on and removed needs review Review pending labels Aug 5, 2019 — with bpmn-io-tasks
philippfromme added a commit to camunda/camunda-bpmn-moddle that referenced this pull request Aug 6, 2019
@philippfromme
fix(extension): fix and refactor extension
ff8bd5c 
* extension wasn't returning anything on 'element.copyProperty'
* check for allowed parent elements

Requires bpmn-io/bpmn-js#1137
@philippfromme philippfromme mentioned this pull request Aug 6, 2019
Closed
@nikku
Copy link
Member

nikku commented Aug 6, 2019

Is this up-to-date with bpmn-io/diagram-js#390?

I still see behavior === false in the code base.

@philippfromme philippfromme force-pushed the 1421-two-step-pasting branch from 07adb8a to 6c14110 Compare August 6, 2019 18:18
@philippfromme
Copy link
Contributor Author

Failing due to camunda/camunda-bpmn-moddle#46.

@philippfromme philippfromme force-pushed the 1421-two-step-pasting branch from 6c14110 to 12bedca Compare August 6, 2019 19:36
@philippfromme philippfromme force-pushed the 1421-two-step-pasting branch 2 times, most recently from ad067df to 39f1d41 Compare August 7, 2019 07:35
@philippfromme
Copy link
Contributor Author

This PR now includes #1141.

@philippfromme
Copy link
Contributor Author

Is this up-to-date with bpmn-io/diagram-js#390?

I still see behavior === false in the code base.

It is now up to date.

@philippfromme philippfromme force-pushed the 1421-two-step-pasting branch 2 times, most recently from 461810c to b6c9d73 Compare August 7, 2019 13:20
philippfromme added a commit to camunda/camunda-bpmn-moddle that referenced this pull request Aug 7, 2019
@philippfromme
fix(extension): fix and refactor extension
73fc024 
* listener wasn't returning anything
* check for allowed parent elements

Requires bpmn-io/bpmn-js#1137
@nikku
Copy link
Member

nikku commented Aug 7, 2019 •
edited
Loading

I've included the latest diagram-js pre-release in the PR.

A single test fails for me locally. Got to check out what's up tomorrow. Can it be because camunda/camunda-bpmn-moddle#46 is not merged yet?

@philippfromme
Copy link
Contributor Author

A single test fails for me locally. Got to check out what's up tomorrow. Can it be because camunda/camunda-bpmn-moddle#46 is not merged yet?

Yes, it is.

@nikku nikku force-pushed the 1421-two-step-pasting branch from 8aaa1e1 to c098f30 Compare August 7, 2019 15:55
philippfromme and others added 4 commits August 7, 2019 17:56
@philippfromme @nikku
feat(create): create multiple elements
b86b26a 
* add <elements.create> rule for creating multiple elements
* handle creating multiple elements in CreateParticipantBehavior
* create sub process with start event through palette
@philippfromme @nikku
chore(copy-paste): rework and base upon diagram-js@5
7274011 
* use <copyPaste.canCopyProperty> event to copy category value when copying group
* add camunda-bpmn-moddle for integration tests

BREAKING CHANGES

* CopyPaste: remove <property.clone>, add <moddleCopy.canCopyProperties>, <moddleCopy.canCopyProperty>, <moddleCopy.canSetCopiedProperty>
* BpmnRules: removed <elements.paste> rule in favor of <elements.create> rule
* BpmnRules: removed <element.paste> rule
* ElementFactory: use <attrs.di> property instead of <attrs.colors> for fill and stroke when creating element through ElementFactory#createBpmnElement
@nikku
chore(project): bump to diagram-js@5.0.0-beta.0
93cb7d2
@nikku
chore(project): update dev dependencies
8a48ba4 
Fix audit warnings.
@nikku nikku force-pushed the 1421-two-step-pasting branch from c098f30 to 8a48ba4 Compare August 7, 2019 15:56
@nikku nikku added needs review Review pending and removed in progress Currently worked on labels Aug 7, 2019 — with bpmn-io-tasks
@nikku nikku self-requested a review August 7, 2019 16:03
nikku
nikku approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥉

@merge-me merge-me bot merged commit 9b2c2c6 into develop Aug 7, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the 1421-two-step-pasting branch August 7, 2019 16:04
@nikku nikku mentioned this pull request Aug 7, 2019
Closed
This was referenced Aug 7, 2019
Closed
Closed
Closed
@ThisIsDemetrio ThisIsDemetrio mentioned this pull request Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinussilvestrus pinussilvestrus pinussilvestrus left review comments

@nikku nikku nikku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
M30
Development

Successfully merging this pull request may close these issues.
3 participants
@philippfromme @nikku @pinussilvestrus