Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnecting sequence flow end to participant throws error #896

Closed
mnp-mid opened this issue Nov 5, 2018 · 2 comments · Fixed by #1067
Closed

Reconnecting sequence flow end to participant throws error #896

mnp-mid opened this issue Nov 5, 2018 · 2 comments · Fixed by #1067
Assignees
@barmac
Labels
bug Something isn't working
Milestone
M29

Comments

@mnp-mid
Copy link

mnp-mid commented Nov 5, 2018 •
edited by philippfromme
Loading

2018-11-05_10-20-48

Reproduce:

  • Reconnect a sequence flow's end to a participant thus turning it into a message flow

Expected Behavior:

  • No error is thrown

Actual Behavior:

Environment

  • Browser: Chrome 70
  • OS: Windows 10
@philippfromme philippfromme changed the title BUG: Moving Sequenz Flow from Task to Participant creates an error in console.log Reconnecting sequence flow end to participant throws error Nov 5, 2018
@philippfromme philippfromme added bug Something isn't working backlog Queued in backlog labels Nov 5, 2018
@nikku nikku added this to the M29 milestone Mar 6, 2019
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Apr 2, 2019
@barmac barmac mentioned this issue May 16, 2019
Closed
@barmac barmac self-assigned this Jun 5, 2019
@barmac
Copy link
Member

barmac commented Jun 5, 2019

Fix for this issue might potentially resolve also this: #1049

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 5, 2019
barmac added a commit that referenced this issue Jun 5, 2019
@barmac
fix(modeling): fix selection after connection replacement
c79e97f 
Closes #896
@barmac barmac mentioned this issue Jun 5, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 5, 2019
barmac added a commit that referenced this issue Jun 5, 2019
@barmac
fix(modeling): fix selection after connection replacement
318c6da 
Closes #896
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jun 5, 2019
barmac added a commit that referenced this issue Jun 5, 2019
@barmac
fix(modeling): fix selection during reconnection with replacement
d92e828 
Closes #896
barmac added a commit that referenced this issue Jun 5, 2019
@barmac
fix(modeling): fix selection during reconnection with replacement
615d39b 
Closes #896
nikku pushed a commit that referenced this issue Jun 5, 2019
@barmac @nikku
fix(modeling): fix selection during reconnection with replacement
d9c873b 
Closes #896
@nikku nikku added needs review Review pending and removed in progress Currently worked on labels Jun 6, 2019 — with bpmn-io-tasks
@pinussilvestrus
Copy link
Contributor

closed via dd3d7e9

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 6, 2019
Ichigo85 pushed a commit to sharedchains/bpmn-js that referenced this issue Aug 29, 2019
@barmac @merge-me
fix(modeling): fix selection during reconnection with replacement
dd3d7e9 
Closes bpmn-io#896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working
Projects
None yet
Milestone
M29
Development

Successfully merging a pull request may close this issue.

Correctly layout and select replaced connection during reconnection bpmn-io/bpmn-js
5 participants
@nikku @philippfromme @pinussilvestrus @barmac @mnp-mid