Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BpmnGlobalConnect provider with rules #870

Closed
barmac opened this issue Oct 10, 2018 · 2 comments
Closed

Replace BpmnGlobalConnect provider with rules #870

barmac opened this issue Oct 10, 2018 · 2 comments
Assignees
@barmac
Labels
enhancement New feature or request

Comments

@barmac
Copy link
Member

barmac commented Oct 10, 2018

Is your feature request related to a problem? Please describe.

New version of diagram-js will break the current implementation of GlobalConnect tool. Because of that, it needs to be adjusted in order to perform an update in the future.

Describe the solution you'd like

Replace BpmnGlobalConnect provider with a rule for connection.start implementing the current logic.

Describe alternatives you've considered

The only alternative would be to not update diagram-js which is not a real alternative. Bumping a version without any changes will break the library.

Additional context

Related #286
@nikku
Copy link
Member

nikku commented Oct 10, 2018

Closes #565.

@nikku nikku added ready Ready to be worked on enhancement New feature or request and removed ready Ready to be worked on labels Oct 10, 2018
barmac added a commit that referenced this issue Oct 11, 2018
@barmac
feat(global-connect): use rules for connection starting
7d3213d 
* remove `BpmnGlobalConnect` provider
* use `connection.start` rule to determine whether
  an element can start a connection

Closes #565
Closes #870

BREAKING CHANGE:

* `BpmnGlobalConnect` got removed. Add `connection.start`
  rule to specify whether connection should be allowed.
@ghost ghost assigned barmac Oct 11, 2018
@ghost ghost added in progress Currently worked on and removed ready Ready to be worked on labels Oct 11, 2018
@barmac barmac mentioned this issue Oct 11, 2018
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Oct 11, 2018
merge-me bot pushed a commit that referenced this issue Oct 11, 2018
@barmac @merge-me
feat(global-connect): use rules for connection starting
ba42e9e 
* remove `BpmnGlobalConnect` provider
* use `connection.start` rule to determine whether
  an element can start a connection

Closes #565
Closes #870

BREAKING CHANGE:

* `BpmnGlobalConnect` got removed. Add `connection.start`
  rule to specify whether connection should be allowed.
@nikku
Copy link
Member

nikku commented Oct 11, 2018

Closed via #871.

@nikku nikku closed this as completed Oct 11, 2018
@ghost ghost removed the needs review Review pending label Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikku @barmac