Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide about whether to revert FONT related changes #819

Closed
nikku opened this issue Jun 28, 2018 · 0 comments
Closed

Decide about whether to revert FONT related changes #819

nikku opened this issue Jun 28, 2018 · 0 comments
Assignees
@nikku
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@nikku
Copy link
Member

nikku commented Jun 28, 2018

The default system font related changes we introduced via 891cf4a break diagrams, including SVG exports (cf. this issue).

We should consider reverting that change.

Library consumers may still override fonts and other things as appropriate and force using the system font.
@nikku nikku added bug Something isn't working help wanted Extra attention is needed labels Jun 28, 2018
@nikku nikku mentioned this issue Jun 28, 2018
Closed
nikku added a commit that referenced this issue Jun 28, 2018
@nikku
fix(draw): revert to Arial as default font
2ba5ad8 
This solves diagram export and rendering issues.

The font can still be easily overriden if integrators
wish to do so.

Closes #819
@ghost ghost assigned nikku Jun 28, 2018
@ghost ghost added the in progress Currently worked on label Jun 28, 2018
@nikku nikku mentioned this issue Jun 28, 2018
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Jun 28, 2018
nikku added a commit that referenced this issue Jun 28, 2018
@nikku
fix(draw): revert to Arial as default font
ed06a12 
This partially reverts commit 891cf4a
which set `sans-serif` as the default font.

Setting it back to Arial solves SVG export and rendering issues,
especially on platforms (Windows, Mac) where the default font
metrics differ highly from Arial.

NOTE: The font can still be easily overriden if integrators wish
to do so in order to give their users a more native look and feel.

Closes #819
philippfromme pushed a commit that referenced this issue Jun 28, 2018
@nikku @philippfromme
fix(draw): revert to Arial as default font
cec9d08 
This partially reverts commit 891cf4a
which set `sans-serif` as the default font.

Setting it back to Arial solves SVG export and rendering issues,
especially on platforms (Windows, Mac) where the default font
metrics differ highly from Arial.

NOTE: The font can still be easily overriden if integrators wish
to do so in order to give their users a more native look and feel.

Closes #819
@ghost ghost removed the needs review Review pending label Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikku