Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching for Plane element results in error #2143

Closed
sentry-io bot opened this issue Apr 18, 2024 · 4 comments · Fixed by #2188
Closed

Searching for Plane element results in error #2143

sentry-io bot opened this issue Apr 18, 2024 · 4 comments · Fixed by #2188
Assignees
@marstamm
Labels
bug Something isn't working good first issue Good for newcomers modeling spring cleaning Could be cleaned up one day

Comments

@sentry-io
Copy link

sentry-io bot commented Apr 18, 2024

Sentry Issue: BPMN-IO-DEMO-7GJ

TypeError: Failed to execute 'setTranslate' on 'SVGTransform': The provided float value is non-finite.
  at apply (bpmn-io-demo/../lib/delegate.js:35:10)
  at sentryWrapped (bpmn-io-demo/../../src/helpers.ts:100:17)
...
(13 additional frame(s) were not displayed)

Steps to reproduce

  • Create a model with a subprocess
  • Press ctrl+c
  • search for "plane"
  • An error is logged in the console + sentry

Additional Info

This does not break the modeler and you can continue with normal modeling after.
@sentry-io sentry-io bot added the bug Something isn't working label Apr 18, 2024
@marstamm
Copy link
Contributor

Note: similar errors are triggered when the plane is selected (through search) and I try to use the context pad. I'll link related errors to this ticket as well
image

@sentry-io Sentry.io
Copy link
Author

sentry-io bot commented Apr 18, 2024

Sentry Issue: BPMN-IO-DEMO-7F1

@sentry-io Sentry.io
Copy link
Author

sentry-io bot commented Apr 18, 2024

Sentry Issue: BPMN-IO-DEMO-5RD

@nikku
Copy link
Member

nikku commented Apr 19, 2024

We never really incorporated plane elements and the search, great we have this bug report open now.

@nikku nikku added modeling good first issue Good for newcomers spring cleaning Could be cleaned up one day backlog Queued in backlog labels Apr 19, 2024
@marstamm marstamm self-assigned this Apr 29, 2024
@marstamm marstamm removed their assignment May 7, 2024
@marstamm marstamm added ready Ready to be worked on and removed backlog Queued in backlog labels May 7, 2024
@nikku nikku mentioned this issue Jun 5, 2024
Closed
marstamm added a commit that referenced this issue Jun 5, 2024
@marstamm
fix(search): do not suggest subprocess planes
be77faf 
closes #2143
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 5, 2024
@marstamm marstamm mentioned this issue Jun 5, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 5, 2024
marstamm added a commit that referenced this issue Jun 5, 2024
@marstamm
fix(search): do not suggest subprocess planes
f470cd5 
closes #2143
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 5, 2024
@github-actions github-actions bot mentioned this issue Jun 17, 2024
Closed
@marstamm marstamm mentioned this issue Jun 19, 2024
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstamm marstamm

Labels
bug Something isn't working good first issue Good for newcomers modeling spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(search): do not suggest subprocess planes bpmn-io/bpmn-js
3 participants
@nikku @marstamm @holygeek00