Vertical participant hit box should contain the top bar

[barmac]

Describe the Bug

The hit box created for a vertical participant is the same as for a horizontal one which leads to confusion.

Steps to Reproduce

Screen.Recording.2024-01-30.at.10.30.15.mov

Expected Behavior

The hit box should contain the top bar and not the space on the left side.

Environment

• Browser: [e.g. IE 11, Chrome 69]
• OS: [e.g. Windows 7]
• Library version: [e.g. 2.0.0]

[sombrek]

This is easy to fix, just a small change in BpmnInteractionEvents.

However, I'm not exactly sure how to tests this. Existing tests don't seem to cover the dimensions or clicks on the hit zone.

[barmac]

Indeed, it looks like a small change. I think the proper tests should also check the dimensions of the hit zones. If you add them for both horizontal and vertical lanes and pools, that will be great.

[sombrek]

@barmac Thanks for your feedback.

Could you please give me a hint on how I can get the dimensions of the hit zone?
Based on BpmnInteractionEventsSpec I tried to get the hit zone element via domQueryAll('.' + HIT_ALL_CLS, gfx), where gfx = elementRegistry.getGraphics(lane);. This does seem to work, but the result is just an empty object {"0":{}}, so I can't check its properties.

[barmac]

Feel free to use this branch as base of your contribution: https://github.com/bpmn-io/bpmn-js/tree/2093-hitboxes

[barmac]

Closed via #2105