Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel Multiple Events are rendered with fill #2085

Closed
sombrek opened this issue Jan 22, 2024 · 1 comment · Fixed by #2089
Closed

Parallel Multiple Events are rendered with fill #2085

sombrek opened this issue Jan 22, 2024 · 1 comment · Fixed by #2089
Labels
bug Something isn't working good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. rendering spring cleaning Could be cleaned up one day

Comments

@sombrek
Copy link
Contributor

sombrek commented Jan 22, 2024

Describe the Bug

Parallel Multiple Events are rendered with a filled trigger. This seems to be a recent regression.

parallel-multiple-events

Steps to Reproduce

  1. Open test/fixtures/bpmn/draw/events.bpmn in bpmn.io
  2. View the parallel multiple events (those with a plus marker)

Expected Behavior

The plus sign in these events should have no fill, per BPMN spec.

parallel-multiple-events-correct

Environment

  • Library version: 16.3.2
@sombrek sombrek added the bug Something isn't working label Jan 22, 2024
@nikku nikku added the pr welcome We rely on a community contribution to improve this. label Jan 23, 2024
@nikku
Copy link
Member

nikku commented Jan 23, 2024

We're happy to take a PR to improve this.

@nikku nikku added good first issue Good for newcomers backlog Queued in backlog spring cleaning Could be cleaned up one day rendering labels Jan 23, 2024
@sombrek sombrek mentioned this issue Jan 26, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Jan 26, 2024
nikku pushed a commit to sombrek/bpmn-js that referenced this issue Jan 29, 2024
@sombrek @nikku
fix(draw): don't fill multiple parallel events
de19f67 
Closes bpmn-io#2085
nikku pushed a commit that referenced this issue Jan 29, 2024
@sombrek @nikku
fix(draw): don't fill multiple parallel events
ec2ee69 
Closes #2085
@barmac barmac mentioned this issue Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. rendering spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple Parallel Events Fill sombrek/bpmn-js
2 participants
@nikku @sombrek