Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append anything breaks modeler when triggered from connection #1813

Closed
Tracked by #1627
barmac opened this issue Jan 23, 2023 · 1 comment · Fixed by #1819
Closed
Tracked by #1627

Append anything breaks modeler when triggered from connection #1813

barmac opened this issue Jan 23, 2023 · 1 comment · Fixed by #1819
Assignees
@smbea
Labels
bug Something isn't working modeling

Comments

@barmac
Copy link
Member

barmac commented Jan 23, 2023 

          Found a way to break it:
Screen.Recording.2023-01-23.at.10.42.54.mov

Easy way to fix this is to disable this functionality for all connections.

Originally posted by @barmac in #1811 (comment)
@barmac barmac added bug Something isn't working ready Ready to be worked on modeling labels Jan 23, 2023
@barmac barmac mentioned this issue Jan 23, 2023
Merged
@smbea
Copy link
Contributor

smbea commented Jan 23, 2023

Makes sense. There is event a isConnection utility that works well here

@smbea smbea self-assigned this Jan 23, 2023
@smbea smbea mentioned this issue Jan 25, 2023
Closed
19 tasks
smbea added a commit that referenced this issue Jan 25, 2023
@smbea
fix(create-append-anything): disallow append menu in connections
943e26c 
Closes #1813
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jan 25, 2023
smbea added a commit that referenced this issue Jan 25, 2023
@smbea
fix(create-append-anything): disallow append menu in connections
e44bc97 
Closes #1813
smbea added a commit that referenced this issue Jan 25, 2023
@smbea
fix(create-append-anything): disallow append menu in connections
70750e5 
Closes #1813
@smbea smbea mentioned this issue Jan 25, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 25, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 27, 2023
barmac pushed a commit that referenced this issue Jan 27, 2023
@smbea @barmac
fix(create-append-anything): disallow append menu in connections
99e7532 
Closes #1813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbea smbea

Labels
bug Something isn't working modeling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(create-append-anything): disallow append menu for connections bpmn-io/bpmn-js
2 participants
@smbea @barmac