Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unremovable selection of sequence flow when adding gateway between start and end event in Firefox #1366

Closed
OmranAbazid opened this issue Nov 6, 2020 · 6 comments
Closed

Unremovable selection of sequence flow when adding gateway between start and end event in Firefox #1366

OmranAbazid opened this issue Nov 6, 2020 · 6 comments
Assignees
@azeghers
Labels
browser:Firefox bug Something isn't working

Comments

@OmranAbazid
Copy link

Describe the Bug

When adding a gateway between start and end event, a weird selection appear on the sequence flow between the start and the gateway

bpmn-sequence-selection

Steps to Reproduce

  1. create a start event
  2. connect it to an end event
  3. drag a gateway into the selection

Expected Behavior

No selection happens on the sequence flow

Environment

  • Browser: Firefox 81.0.2
  • OS: Mac osx
  • Library version: latest
@OmranAbazid OmranAbazid added the bug Something isn't working label Nov 6, 2020
@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Nov 6, 2020 •
edited
Loading

Thanks for reporting! Thehover marker got added after dropping, exclusively in Firefox.

image

@nikku
Copy link
Member

nikku commented Nov 12, 2020

Can reproduce this one on Linux, Firefox latest, too.

@nikku nikku added the ready Ready to be worked on label Nov 12, 2020 — with bpmn-io-tasks
@barmac
Copy link
Member

barmac commented Nov 19, 2020

I was able to reproduce it on Firefox 80

@nikku nikku changed the title in Firefox: unremovable selection of sequence flow when adding gateway between start and end event Unremovable selection of sequence flow when adding gateway between start and end event in Firefox Nov 19, 2020
@azeghers
Copy link
Contributor

Small finding, hovering over anything other than the segment-dragger on the Flow removes the problematic selection.

unremovable-selection

@azeghers
Copy link
Contributor

Possible fix :

firefox-2020-11-23-190123

@azeghers azeghers added in progress Currently worked on and removed ready Ready to be worked on labels Nov 24, 2020
azeghers added a commit to bpmn-io/diagram-js that referenced this issue Nov 24, 2020
@azeghers
fix(dragging): remove hover class of hovered element on drop
d9d90aa 
Related to bpmn-io/bpmn-js#1366
@azeghers azeghers mentioned this issue Nov 24, 2020
Closed
9 tasks
nikku added a commit to bpmn-io/diagram-js that referenced this issue Nov 26, 2020
@nikku
fix: generalize fix for swallowed hover events
b1bb1e2 
Replaces the old drag hover fix (which fixed kindof the same thing)
with one that works in a general fashion only on element.* level.

Closes bpmn-io/bpmn-js#1366

----

MISSING:

* tests
azeghers pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 27, 2020
@nikku @azeghers
fix: generalize fix for swallowed hover events
3cc62fb 
Replaces the old drag hover fix (which fixed kindof the same thing)
with one that works in a general fashion only on element.* level.

Closes bpmn-io/bpmn-js#1366
azeghers pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 29, 2020
@nikku @azeghers
fix: generalize fix for swallowed hover events
776afcf 
Replaces the old drag hover fix (which fixed kindof the same thing)
with one that works in a general fashion only on element.* level.

Closes bpmn-io/bpmn-js#1366
@azeghers azeghers mentioned this issue Nov 29, 2020
Merged
9 tasks
azeghers pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 29, 2020
@nikku @azeghers
fix: generalize fix for swallowed hover events
bcfcec2 
Replaces the old drag hover fix (which fixed kindof the same thing)
with one that works in a general fashion only on element.* level.

Closes bpmn-io/bpmn-js#1366
azeghers pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 29, 2020
@nikku @azeghers
fix: generalize fix for swallowed hover events
29c58d4 
Replaces the old drag hover fix (which fixed kindof the same thing)
with one that works in a general fashion only on element.* level.

Closes bpmn-io/bpmn-js#1366
azeghers pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 29, 2020
@nikku @azeghers
fix: generalize fix for swallowed hover events
eee7816 
Replaces the old drag hover fix (which fixed kindof the same thing)
with one that works in a general fashion only on element.* level.

Closes bpmn-io/bpmn-js#1366
@pinussilvestrus pinussilvestrus added needs review Review pending and removed in progress Currently worked on labels Nov 30, 2020 — with bpmn-io-tasks
azeghers pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 30, 2020
@nikku @azeghers
fix: generalize fix for swallowed hover events
34befbf 
Replaces the old drag hover fix (which fixed kindof the same thing)
with one that works in a general fashion only on element.* level.

Related to bpmn-io/bpmn-js#1366
azeghers pushed a commit to bpmn-io/diagram-js that referenced this issue Dec 1, 2020
@nikku @azeghers
fix: generalize fix for swallowed hover events
52c5f87 
Replaces the old drag hover fix (which fixed kindof the same thing)
with one that works in a general fashion only on element.* level.

Related to bpmn-io/bpmn-js#1366
nikku added a commit to bpmn-io/diagram-js that referenced this issue Dec 1, 2020
@nikku
fix: generalize fix for swallowed hover events
eacd65c 
Replaces the old drag hover fix (which fixed kindof the same thing)
with one that works in a general fashion only on element.* level.

Related to bpmn-io/bpmn-js#1366
@azeghers azeghers added fixed upstream Requires integration of upstream change and removed needs review Review pending labels Dec 1, 2020 — with bpmn-io-tasks
@nikku nikku closed this as completed in 617757e Dec 1, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Dec 1, 2020
@nikku
Copy link
Member

nikku commented Dec 2, 2020

Fix released with v7.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azeghers azeghers

Labels
browser:Firefox bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nikku @OmranAbazid @pinussilvestrus @barmac @azeghers