Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events are not triggered on elements inside group for Viewer and NavigatedViewer #1278

Closed
OmranAbazid opened this issue Feb 6, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@OmranAbazid
Copy link

Describe the Bug

For the Viewer and the NavigtatedView, bpmnjs events(e.g hover, click) do not fire on elements inside of a group
For the modeler, it works fine.

Steps to Reproduce

  1. Load into a NavigatedViewer a BPMN diagram that has a group element and some flow nodes inside
  2. attached a click or hover to the viewer instance that console logs the element name
  3. click or hover over the elements inside the group
  4. clicking on elements inside the groups logs only the group name

Please see the example here

Expected Behavior
The event triggers on the child element of the group exactly like the modeler

Environment

  • Browser: Chrome 80
  • OS: MacOS high sierra
  • Library version: 6.1.2
@OmranAbazid OmranAbazid added the bug Something isn't working label Feb 6, 2020
@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Feb 6, 2020

Thanks for reporting and sharing the example!

Seems like the pointer-events: stroke property is not properly set on groups inside the Viewer. Probably because the isFrame attribute is not set when rendering the group element.

Setting this property belongs to the ElementFactory, which is not available in the Viewer classes. We should find a better place for it.

@pinussilvestrus pinussilvestrus self-assigned this Feb 6, 2020
@pinussilvestrus pinussilvestrus added the in progress Currently worked on label Feb 6, 2020
pinussilvestrus pushed a commit that referenced this issue Feb 6, 2020
pinussilvestrus pushed a commit that referenced this issue Feb 7, 2020
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 7, 2020
pinussilvestrus pushed a commit that referenced this issue Feb 7, 2020
@nikku nikku added the fixed upstream Requires integration of upstream change label Feb 7, 2020
@nikku
Copy link
Member

nikku commented Feb 7, 2020

Addressed via #1279.

@nikku nikku closed this as completed in 566f0ea Feb 7, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed fixed upstream Requires integration of upstream change needs review Review pending labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants