Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary event associations can be created but can't be loaded #1170

Closed
AndyBan opened this issue Aug 13, 2019 · 6 comments · Fixed by #1172
Closed

Boundary event associations can be created but can't be loaded #1170

AndyBan opened this issue Aug 13, 2019 · 6 comments · Fixed by #1172
Assignees
Labels
bug Something isn't working
Milestone

Comments

@AndyBan
Copy link

AndyBan commented Aug 13, 2019

Describe the Bug

Associations on bpmn:BoundaryEvents can be modeled, bu won't be rendered on import.

Created:
image

After load:

image

Steps to Reproduce

Using https://demo.bpmn.io/new

  1. Create Task
  2. Add signal boundary event (Happens for other boundary events too)
  3. Associate boundary event with data object
  4. Export to file, refresh, import from file

Expected Behavior

Associations on Boundary Events will be rendered correctly.

Environment

  • Browser: all
  • OS: macOS
  • Library version: 3, 4, 5
@AndyBan AndyBan changed the title Boundary event associations don't parse Boundary event associations don't load Aug 13, 2019
@AndyBan AndyBan changed the title Boundary event associations don't load Boundary event associations can be created but can't be loaded Aug 14, 2019
@pinussilvestrus pinussilvestrus added the bug Something isn't working label Aug 19, 2019
@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Aug 19, 2019

Was able to reproduce it on Chrome (for several kinds of Boundary Events). It also appears in older bpmn-js versions (tested under v3).

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Aug 19, 2019

Changed the issue description to fit our template.

@pinussilvestrus pinussilvestrus added the in progress Currently worked on label Aug 19, 2019 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus self-assigned this Aug 19, 2019
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 19, 2019
@nikku
Copy link
Member

nikku commented Aug 19, 2019

Closed via #1172.

@nikku nikku closed this as completed Aug 19, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 19, 2019
@nikku nikku added this to the M31 milestone Aug 19, 2019
@AndyBan
Copy link
Author

AndyBan commented Aug 20, 2019

@nikku

I have tested using npm@5.0.1 and on https://demo.bpmn.io/ and fix doesn't appear to have worked with edge@78 and firefox@68.

Functionality looks to be the same as before where data association isn't displayed. The produced xml looks fine though:

<?xml version="1.0" encoding="UTF-8"?>
<bpmn:definitions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" id="Definitions_1dldzfo" targetNamespace="http://bpmn.io/schema/bpmn" exporter="bpmn-js (https://demo.bpmn.io)" exporterVersion="5.0.0">
  <bpmn:process id="Process_0akyfq7" isExecutable="false">
    <bpmn:startEvent id="StartEvent_1k7b65z">
      <bpmn:outgoing>SequenceFlow_0ljsapo</bpmn:outgoing>
    </bpmn:startEvent>
    <bpmn:task id="Task_087uhhc">
      <bpmn:incoming>SequenceFlow_0ljsapo</bpmn:incoming>
    </bpmn:task>
    <bpmn:sequenceFlow id="SequenceFlow_0ljsapo" sourceRef="StartEvent_1k7b65z" targetRef="Task_087uhhc" />
    <bpmn:boundaryEvent id="BoundaryEvent_1fbn91z" attachedToRef="Task_087uhhc">
      <bpmn:outgoing>SequenceFlow_0lo5gt4</bpmn:outgoing>
      <bpmn:dataOutputAssociation id="DataOutputAssociation_027acd9">
        <bpmn:targetRef>DataObjectReference_1k5ejq4</bpmn:targetRef>
      </bpmn:dataOutputAssociation>
    </bpmn:boundaryEvent>
    <bpmn:task id="Task_1dryxgw">
      <bpmn:incoming>SequenceFlow_0lo5gt4</bpmn:incoming>
    </bpmn:task>
    <bpmn:sequenceFlow id="SequenceFlow_0lo5gt4" sourceRef="BoundaryEvent_1fbn91z" targetRef="Task_1dryxgw" />
    <bpmn:dataObjectReference id="DataObjectReference_1k5ejq4" dataObjectRef="DataObject_0op3ch8" />
    <bpmn:dataObject id="DataObject_0op3ch8" />
  </bpmn:process>
  <bpmndi:BPMNDiagram id="BPMNDiagram_1">
    <bpmndi:BPMNPlane id="BPMNPlane_1" bpmnElement="Process_0akyfq7">
      <bpmndi:BPMNShape id="_BPMNShape_StartEvent_2" bpmnElement="StartEvent_1k7b65z">
        <dc:Bounds x="156" y="81" width="36" height="36" />
      </bpmndi:BPMNShape>
      <bpmndi:BPMNShape id="Task_087uhhc_di" bpmnElement="Task_087uhhc">
        <dc:Bounds x="250" y="59" width="100" height="80" />
      </bpmndi:BPMNShape>
      <bpmndi:BPMNEdge id="SequenceFlow_0ljsapo_di" bpmnElement="SequenceFlow_0ljsapo">
        <di:waypoint x="192" y="99" />
        <di:waypoint x="250" y="99" />
      </bpmndi:BPMNEdge>
      <bpmndi:BPMNShape id="BoundaryEvent_1fbn91z_di" bpmnElement="BoundaryEvent_1fbn91z">
        <dc:Bounds x="272" y="121" width="36" height="36" />
      </bpmndi:BPMNShape>
      <bpmndi:BPMNShape id="Task_1dryxgw_di" bpmnElement="Task_1dryxgw">
        <dc:Bounds x="360" y="180" width="100" height="80" />
      </bpmndi:BPMNShape>
      <bpmndi:BPMNEdge id="SequenceFlow_0lo5gt4_di" bpmnElement="SequenceFlow_0lo5gt4">
        <di:waypoint x="290" y="157" />
        <di:waypoint x="290" y="220" />
        <di:waypoint x="360" y="220" />
      </bpmndi:BPMNEdge>
      <bpmndi:BPMNShape id="DataObjectReference_1k5ejq4_di" bpmnElement="DataObjectReference_1k5ejq4">
        <dc:Bounds x="162" y="245" width="36" height="50" />
      </bpmndi:BPMNShape>
      <bpmndi:BPMNEdge id="DataOutputAssociation_027acd9_di" bpmnElement="DataOutputAssociation_027acd9">
        <di:waypoint x="279" y="153" />
        <di:waypoint x="198" y="251" />
      </bpmndi:BPMNEdge>
    </bpmndi:BPMNPlane>
  </bpmndi:BPMNDiagram>
</bpmn:definitions>

@pinussilvestrus
Copy link
Contributor

It works perfectly fine to me on yesterday's released version (tag v5.0.1). However, it's not shipped to https://demo.bpmn.io right now.

@AndyBan
Copy link
Author

AndyBan commented Aug 20, 2019

Oh I do apologize, had a bit of a caching issue and it is indeed working, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants