Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After pasting task direct editing is enabled #1164

Closed
pinussilvestrus opened this issue Aug 12, 2019 · 2 comments · Fixed by #1168
Closed

After pasting task direct editing is enabled #1164

pinussilvestrus opened this issue Aug 12, 2019 · 2 comments · Fixed by #1168
Assignees
@pinussilvestrus
Labels
bug Something isn't working
Milestone
M30

Comments

@pinussilvestrus
Copy link
Contributor

Describe the Bug

After pasting certain elements, with a task on first position, direct editing is activated for the task element.

Kapture 2019-08-12 at 11 54 12

#1152 aimed to solve this by selecting all elements after pasting, but it's still present. The bug is not appearing if a non-task element is in the first position.

Steps to Reproduce

  1. Copy a bunch of elements with a task in the first position
  2. Paste --> direct editing is activated for the task in first position

Expected Behavior

Direct editing is not activated at all.

Environment

  • Browser: Chrome 76
  • OS: MacOS 10.14
  • Library version: 5.0.0-beta.2
@pinussilvestrus pinussilvestrus added the bug Something isn't working label Aug 12, 2019
@nikku
Copy link
Member

nikku commented Aug 12, 2019

This should have been fixed via #1152.

But never mind, was not part of the issue description 😉.

@nikku nikku added this to the M30 milestone Aug 12, 2019
@nikku nikku added the ready Ready to be worked on label Aug 12, 2019
@pinussilvestrus pinussilvestrus self-assigned this Aug 12, 2019
@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed ready Ready to be worked on labels Aug 12, 2019 — with bpmn-io-tasks
pinussilvestrus pushed a commit that referenced this issue Aug 12, 2019
fix(label-editing): prevent direct editing after hint available
37fcc4e 
Closes #1164
pinussilvestrus pushed a commit that referenced this issue Aug 12, 2019
fix(label-editing): prevent direct editing after create
2d8df39 
Closes #1164
@pinussilvestrus pinussilvestrus mentioned this issue Aug 12, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 12, 2019
@nikku
Copy link
Member

nikku commented Aug 13, 2019

Closed via #1168

@nikku nikku closed this as completed Aug 13, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 13, 2019
barmac pushed a commit that referenced this issue Aug 13, 2019
@merge-me
fix(label-editing): prevent direct editing after create
715d2cc 
Closes #1164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
bug Something isn't working
Projects
None yet
Milestone
M30
Development

Successfully merging a pull request may close this issue.

fix(label-editing): prevent direct editing after create bpmn-io/bpmn-js
2 participants
@nikku @pinussilvestrus