Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inverse space tool visuals broken #1105

Closed
1 task
nikku opened this issue Jun 25, 2019 · 1 comment
Closed
1 task

Inverse space tool visuals broken #1105

nikku opened this issue Jun 25, 2019 · 1 comment
Assignees
@philippfromme
Labels
bug Something isn't working
Milestone
M29

Comments

@nikku
Copy link
Member

nikku commented Jun 25, 2019

Describe the Bug

You can activate the inverse space tool by pressing the CTRL modifier key. It works as expected but does not show the correct visuals for container resizing:

bug

Steps to Reproduce

  • Go to demo
  • Add participant
  • CTRL + move space tool to make space on top
  • Observe missleading / wrong visuals

Expected Behavior

  • Visuals indicate resize is actually an expand.

Environment

Please complete the following information:

  • Browser: Any
  • OS: Any
  • Library version: v4.0.0-beta.4
@nikku nikku added the ready Ready to be worked on label Jun 25, 2019 — with bpmn-io-tasks
@nikku nikku added the bug Something isn't working label Jun 25, 2019
@nikku nikku added this to the M29 milestone Jun 25, 2019
@barmac barmac added backlog Queued in backlog and removed ready Ready to be worked on labels Jun 28, 2019 — with bpmn-io-tasks
@philippfromme philippfromme added ready Ready to be worked on and removed backlog Queued in backlog labels Jul 4, 2019 — with bpmn-io-tasks
@philippfromme philippfromme self-assigned this Jul 4, 2019
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jul 4, 2019
@philippfromme
fix(space-tool-preview): correctly update resize previews
d011218 
Related to bpmn-io/bpmn-js#1105
@philippfromme philippfromme mentioned this issue Jul 4, 2019
Merged
@nikku nikku modified the milestones: M29, M30 Jul 5, 2019
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jul 5, 2019
@philippfromme
fix(space-tool-preview): correctly update resize previews
b2001a2 
Related to bpmn-io/bpmn-js#1105
merge-me bot pushed a commit to bpmn-io/diagram-js that referenced this issue Jul 5, 2019
@philippfromme @merge-me
fix(space-tool-preview): correctly update resize previews
94644d7 
Related to bpmn-io/bpmn-js#1105
@nikku
Copy link
Member Author

nikku commented Jul 5, 2019

Closed via bpmn-io/diagram-js#380.

@nikku nikku closed this as completed Jul 5, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Jul 5, 2019
nikku added a commit that referenced this issue Jul 8, 2019
@nikku
chore(project): bump diagram-js version
202eff5 
Closes #746
Closes #1105
@nikku nikku modified the milestones: M30, M29 Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working
Projects
None yet
Milestone
M29
Development

No branches or pull requests
3 participants
@nikku @philippfromme @barmac