feat: enable connection tool for text annotation

fixes upstream camunda/camunda-modeler#2042
bpmn-io · Apr 7, 2021 · 40f1d3a · 40f1d3a
1 parent c58af15
commit 40f1d3a
Show file tree

Hide file tree

Showing 5 changed files with 58 additions and 17 deletions.
diff --git a/lib/features/context-pad/ContextPadProvider.js b/lib/features/context-pad/ContextPadProvider.js
@@ -362,27 +362,49 @@ ContextPadProvider.prototype.getContextPadEntries = function(element) {
     });
   }
 
-  if (isAny(businessObject, [
-    'bpmn:FlowNode',
-    'bpmn:InteractionNode',
-    'bpmn:DataObjectReference',
-    'bpmn:DataStoreReference'
-  ])) {
-
+  if (
+    isAny(businessObject, [
+      'bpmn:FlowNode',
+      'bpmn:InteractionNode',
+      'bpmn:DataObjectReference',
+      'bpmn:DataStoreReference',
+    ])
+  ) {
     assign(actions, {
-      'append.text-annotation': appendAction('bpmn:TextAnnotation', 'bpmn-icon-text-annotation'),
+      'append.text-annotation': appendAction(
+        'bpmn:TextAnnotation',
+        'bpmn-icon-text-annotation'
+      ),
 
       'connect': {
         group: 'connect',
         className: 'bpmn-icon-connection-multi',
-        title: translate('Connect using ' +
-                  (businessObject.isForCompensation ? '' : 'Sequence/MessageFlow or ') +
-                  'Association'),
+        title: translate(
+          'Connect using ' +
+            (businessObject.isForCompensation
+              ? ''
+              : 'Sequence/MessageFlow or ') +
+            'Association'
+        ),
         action: {
           click: startConnect,
-          dragstart: startConnect
-        }
-      }
+          dragstart: startConnect,
+        },
+      },
+    });
+  }
+
+  if (is(businessObject, 'bpmn:TextAnnotation')) {
+    assign(actions, {
+      'connect': {
+        group: 'connect',
+        className: 'bpmn-icon-connection-multi',
+        title: translate('Connect using Association'),
+        action: {
+          click: startConnect,
+          dragstart: startConnect,
+        },
+      },
     });
   }
 

diff --git a/lib/features/rules/BpmnRules.js b/lib/features/rules/BpmnRules.js
@@ -213,7 +213,8 @@ function canStartConnection(element) {
     'bpmn:InteractionNode',
     'bpmn:DataObjectReference',
     'bpmn:DataStoreReference',
-    'bpmn:Group'
+    'bpmn:Group',
+    'bpmn:TextAnnotation'
   ]);
 }
 

diff --git a/test/spec/features/context-pad/ContextPad.activation.bpmn b/test/spec/features/context-pad/ContextPad.activation.bpmn
@@ -12,6 +12,9 @@
     <bpmn2:dataObject id="DataObject_1" name="Data Object 1"/>
     <bpmn2:dataObjectReference id="DataObjectReference" dataObjectRef="DataObject_1"/>
     <bpmn2:group id="Group_1" categoryValueRef="CategoryValue_1" />
+    <bpmn2:textAnnotation id="TextAnnotation_1">
+      <bpmn2:text>simple text annotation</bpmn2:text>
+    </bpmn2:textAnnotation>
   </bpmn2:process>
   <bpmn2:category id="Category_1">
     <bpmn2:categoryValue id="CategoryValue_1" />
@@ -54,6 +57,9 @@
       <bpmndi:BPMNShape id="Group_1_di" bpmnElement="Group_1">
         <dc:Bounds x="40" y="410" width="190" height="110" />
       </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="TextAnnotation_1_di" bpmnElement="TextAnnotation_1">
+        <dc:Bounds x="760" y="120" width="100" height="30" />
+      </bpmndi:BPMNShape>
     </bpmndi:BPMNPlane>
   </bpmndi:BPMNDiagram>
-</bpmn2:definitions>
+</bpmn2:definitions>
diff --git a/test/spec/features/context-pad/ContextPadProviderSpec.js b/test/spec/features/context-pad/ContextPadProviderSpec.js
@@ -291,6 +291,17 @@ describe('features - context-pad', function() {
       ]);
     }));
 
+
+    it('should provide Text Annotation entries', inject(function() {
+
+      expectContextPadEntries('TextAnnotation_1', [
+        'connect',
+        'delete',
+        '!replace',
+        '!append.text-annotation'
+      ]);
+    }));
+
   });
 
 

diff --git a/test/spec/features/rules/BpmnRulesSpec.js b/test/spec/features/rules/BpmnRulesSpec.js
@@ -2255,7 +2255,8 @@ describe('features/modeling/rules - BpmnRules', function() {
         'bpmn:InteractionNode',
         'bpmn:DataObjectReference',
         'bpmn:DataStoreReference',
-        'bpmn:Group'
+        'bpmn:Group',
+        'bpmn:TextAnnotation'
       ];
 
       // when