codegen: kfunc: Read correct sized argument #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danobi
force-pushed
the
kfunc_arg_size
branch
2 times, most recently
from
9f18c74
to
ac1ed7c
Compare
Before, we were always reading 64 bits for the arg. The arg does not _have_ to be 64 bits wide, it can also be 32 bits wide for example. If it's 32 bits, the upper 32 bits are junk, so reading it is not ok. Fix by reading the correct size integer.
danobi
force-pushed
the
kfunc_arg_size
branch
from
ac1ed7c
to
f38f8e4
Compare
viktormalik
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were always reading 64 bits for the arg. The arg does not
have to be 64 bits wide, it can also be 32 bits wide for example. If
it's 32 bits, the upper 32 bits are junk, so reading it is not ok.
Fix by reading the correct size integer.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md