Use Ubuntu 24.04 everywhere #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need kernel version 6.6 or greater to build the tcx test container images and also to run tcx integration tests. We also have potential incompatibilies because redhat/ubi9-minimal is being used in Containerfile.bpfman.multi.arch, but ubuntu is being used to build the executables in image-build.yml. Using Ubuntu-latest also has the potential to change versions without our knowing so we should pin down the version. Signed-off-by: Andre Fredette <afredette@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1324 +/- ##
=====================================
Coverage 8.94% 8.94%
=====================================
Files 24 24
Lines 6027 6027
=====================================
Hits 539 539
Misses 5488 5488 ☔ View full report in Codecov by Sentry. |
dave-tucker
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need kernel version 6.6 or greater to build the tcx test container images and also to run tcx integration tests.
We also have potential incompatibilies because redhat/ubi9-minimal is being used in Containerfile.bpfman.multi.arch, but ubuntu is being used to build the executables in image-build.yml.
Using Ubuntu-latest also has the potential to change versions without our knowing so we should pin down the version.
Using Ubuntu 24.04 for the bpfman image build and container can be revisited if we move to the approach in #1253.