Enable Integration Tests to Use Podman-Built Images #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 27.61% 27.61%
=======================================
Files 81 81
Lines 6999 6999
=======================================
Hits 1933 1933
Misses 4877 4877
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/test bpfman-agent-on-pull-request |
Created a new loadimagearchive addon by copying and adapting the existing loadimage addon from github.com/kong/kubernetes-testing-framework/pkg/clusters/addons/loadimage. This new addon extends functionality to support both Podman and Docker by saving images as tarballs and loading them into kind clusters using `kind load image-archive`. Signed-off-by: Andrew McDermott <amcdermo@redhat.com>
Modified the Makefile to respect the `OCI_BIN` environment variable, switching from `kind load docker-image` to `kind load image-archive`. This change enables support for both Docker and Podman, depending on the value of `OCI_BIN`. Updated the integration test suite to utilise the new loadimagearchive addon instead of the original loadimage addon. The addon also respects the `OCI_BIN` variable, ensuring images are loaded into kind clusters from the correct container engine. Signed-off-by: Andrew McDermott <amcdermo@redhat.com>
frobware
force-pushed
the
test-integration-support-podman-and-docker-v2
branch
from
405ed9e to
208c718
Compare
msherif1234
pushed a commit
to msherif1234/bpfman-operator
that referenced
this pull request
Nov 15, 2024
…/ocp-bpfman-operator-bundle chore(deps): update ocp-bpfman-operator-bundle to 1eb24b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96.
Summary
This PR ensures that the value of
OCI_BINnow determines whether images are loaded from Podman or Docker during integration tests, addressing the issue detailed in Integration Tests Not Using Podman-Built Images. The key updates include:Addition of the
loadimagearchiveAddon: A new addon,loadimagearchive, has been created by adapting the existing github.com/kong/kubernetes-testing-framework/pkg/clusters/addons/loadimage addon. This new addon supports both Docker and Podman by saving images as tarballs and loading them into kind clusters using thekind load image-archivecommand. The addon determines which container engine to use based on the value of theOCI_BINenvironment variable, ensuring that the correct images are loaded into the cluster.Makefile Updates: The
load-images-kindtarget now respects the value ofOCI_BINand has been reworked to load images viakind load image-archive, similar to the new addon. This change ensures that images corresponding to the specifiedOCI_BIN(either Docker or Podman) are correctly loaded into the kind cluster.Integration Test Suite: The test suite has been updated to use the new
loadimagearchiveaddon.