Add downstream container files and update the konflux pipeline #90
Conversation
msherif1234
force-pushed
the
ds-dockerfiles
branch
from
88c15da to
a87bf83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 27.61% 27.61%
=======================================
Files 81 81
Lines 6999 6999
=======================================
Hits 1933 1933
Misses 4877 4877
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Containerfile.bpfman-agent.openshift
Outdated
|
|
||
| # cache deps before building and copying source so that we don't need to re-download as much | ||
| # and so that source changes don't invalidate our downloaded layer | ||
| RUN go mod download |
There was a problem hiding this comment.
Shouldn't the vendor directory already be up to date? The expectation is that go mod tidy and go mod vendor are run for each commit, ensuring consistency and avoiding the need to download dependencies locally or in CI.
Any commit should trigger a CI check for go mod tidy. If this check reports a difference, the commit is incomplete and should not be merged.
Containerfile.bpfman-agent.openshift
Outdated
| # Install crictl | ||
| RUN dnf -y install wget tar gzip | ||
| ARG VERSION="v1.28.0" | ||
| RUN wget --no-check-certificate https://github.com/kubernetes-sigs/cri-tools/releases/download/${VERSION}/crictl-${VERSION}-linux-${TARGETARCH}.tar.gz |
There was a problem hiding this comment.
Why do we need to disable certificate checking, especially for connections to github.com?
| ARG TARGETARCH | ||
| ARG TARGETPLATFORM | ||
|
|
||
| RUN echo "TARGETOS=${TARGETOS} TARGETARCH=${TARGETARCH} BUILDPLATFORM=${BUILDPLATFORM} TARGETPLATFORM=${TARGETPLATFORM}" |
There was a problem hiding this comment.
nit: there's double spaces between each env key/value pair that is being echoed.
Containerfile.bpfman-agent.openshift
Outdated
| # the docker BUILDPLATFORM arg will be linux/arm64 when for Apple x86 it will be linux/amd64. Therefore, | ||
| # by leaving it empty we can ensure that the container and binary shipped on it will have the same platform. | ||
| WORKDIR /usr/src/bpfman-operator | ||
| RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -mod vendor -a -o bpfman-agent ./cmd/bpfman-agent/main.go |
There was a problem hiding this comment.
Do we really need the -a flag? We're building in a fresh container, so everything that needs building will get rebuilt regardless. Additionally, CI implicitly ensures a complete build.
msherif1234
force-pushed
the
ds-dockerfiles
branch
7 times, most recently
from
93db2b3 to
6d92ddc
Compare
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
msherif1234
force-pushed
the
ds-dockerfiles
branch
from
6d92ddc to
5e39cd9
Compare
…/ocp-bpfman-operator-bundle chore(deps): update ocp-bpfman-operator-bundle to 42b90d0
No description provided.