Add catalog index file and script to generate it #82
Conversation
|
@OlivierCazade, you'll need to sign off on your commit to pass the DCO checks. |
Makefile
Outdated
| @@ -361,6 +361,10 @@ ifneq ($(origin CATALOG_BASE_IMG), undefined) | |||
| FROM_INDEX_OPT := --from-index $(CATALOG_BASE_IMG) | |||
| endif | |||
|
|
|||
| .PHONY: catalog-update | |||
| catalog-update: | |||
There was a problem hiding this comment.
pls add ## Generate catalog yaml for konflux or something like that to show in
make help
| @@ -5,9 +5,9 @@ ENTRYPOINT ["/bin/opm"] | |||
| CMD ["serve", "/configs", "--cache-dir=/tmp/cache"] | |||
|
|
|||
| # Copy declarative config root into image at /configs and pre-populate serve cache | |||
| ADD bpfman-operator-catalog /configs | |||
| ADD catalog /configs | |||
There was a problem hiding this comment.
if u will use catalog as folder then pls delete bpfman-operator-catalog folder
| cat <<EOF >"${CATALOG_FILE}" | ||
| --- | ||
| defaultChannel: latest | ||
| icon: |
There was a problem hiding this comment.
What icon are you using? Does it need to be embedded in the script like this, or could you upload and point to the svg file?
There was a problem hiding this comment.
this bpfman log and it can be verified using https://base64.guru/converter/decode/image
and other operators doing the same the also embedded that way so we are following alone
There was a problem hiding this comment.
I used the one from the bundle:
I can include it in a separate file and make the script use it if you prefer.
There was a problem hiding this comment.
no that is good enough Thanks
OlivierCazade
force-pushed
the
fbc-index
branch
2 times, most recently
from
281911e to
b33f2cd
Compare
Signed-off-by: Olivier Cazade <ocazade@redhat.com>
OlivierCazade
force-pushed
the
fbc-index
branch
from
b33f2cd to
73c01fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 27.61% 27.61%
=======================================
Files 81 81
Lines 6999 6999
=======================================
Hits 1933 1933
Misses 4877 4877
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…/ocp-bpfman-operator chore(deps): update ocp-bpfman-operator to ebeda02
The script generate a catalog index file using the current bundle.
The bundle must be reachable from a repository, it can not only be built localy.