Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add make catalog-deploy to allow loading dev operator from console #43

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Add make catalog-deploy to allow loading dev operator from console #43

merged 1 commit into from
Jul 12, 2024

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 11, 2024 •
edited
Loading

fixes bpfman/bpfman#1178

Steps

export CATALOG_IMG=quay.io/$USER/bpfman-operator-catalog:v$VERSION
make catalog-build
make catalog-push
make catalog-deploy

image

image

oc get pods -n openshift-bpfman
NAME                              READY   STATUS    RESTARTS   AGE
bpfman-operator-dd8b8887c-5sxfl   2/2     Running   0          4m16s

@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.40%. Comparing base (6f6e6ee) to head (f651027).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   27.40%   27.40%           
=======================================
  Files          81       81           
  Lines        6965     6965           
=======================================
  Hits         1909     1909           
  Misses       4870     4870           
  Partials      186      186
Flag Coverage Δ
unittests 27.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024

@msherif1234, this pull request is now in conflict and requires a rebase.

@mergify mergify bot added the needs-rebase label Jul 11, 2024
@mergify mergify bot removed the needs-rebase label Jul 11, 2024
@msherif1234 msherif1234 requested a review from anfredette July 11, 2024 20:06
@msherif1234 msherif1234 changed the title Add make catalog-deploy to allow loading opertor to operator hub Add make catalog-deploy to allow loading dev opertor to operator hub Jul 11, 2024
@astoycos
Copy link
Member

If you're updating the deploy namespace you'll also need to update the namespace

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 12, 2024

@msherif1234, this pull request is now in conflict and requires a rebase.

@mergify mergify bot added the needs-rebase label Jul 12, 2024
@mergify mergify bot removed the needs-rebase label Jul 12, 2024
@msherif1234 msherif1234 changed the title Add make catalog-deploy to allow loading dev opertor to operator hub Add make catalog-deploy to allow loading dev operator from console Jul 12, 2024
astoycos
astoycos reviewed Jul 12, 2024
View reviewed changes
README.md Outdated

```sh
export BUNDLE_IMG=quay.io/$USER/bpfman-operator-bundle:v$VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT, $VERSION may not exist here, either just recommend a dev tag or tell the user to set Version above

Suggested change
export BUNDLE_IMG=quay.io/$USER/bpfman-operator-bundle:v$VERSION
export BUNDLE_IMG=quay.io/$USER/bpfman-operator-bundle:development

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

astoycos
astoycos reviewed Jul 12, 2024
View reviewed changes
config/samples/catalog/catalog.yaml Outdated
@@ -0,0 +1,13 @@
apiVersion: operators.coreos.com/v1alpha1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should go in config/samples/catalog what about in it's own config directory? i.e config/catalog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just used the same layout we used in NOO but since this just for dev not sure if we should expose outside samples but I am fine either way, do u have motivation for it being under config ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I don't care that much I just think isn't a sample at all, you could even put it under hack/ since really it's just a hack to preview the developer in operatorhub

Otherwise I don't care too much, if you want to leave it here that's fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved out under config

astoycos
astoycos reviewed Jul 12, 2024
View reviewed changes
README.md Outdated
[Developing the bpfman-operator](https://bpfman.io/v0.5.0-rc1/developer-guide/develop-operator)

### Deploy as a bundle from the Console's OperatorHub page
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit can you move this up to the Deploy bpfman Operator section?

astoycos
astoycos reviewed Jul 12, 2024
View reviewed changes
README.md Outdated

This mode is recommended when you want to test the customer experience of navigating through the operators'
catalog and installing/configuring it manually through the UI.
Copy link
Member

@astoycos astoycos Jul 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
catalog and installing/configuring it manually through the UI.
catalog and installing/configuring it manually through the UI. Prior to committing the bundle to [community-operators](https://github.com/redhat-openshift-ecosystem/community-operators-prod) or [community-operators-prod](https://github.com/k8s-operatorhub/community-operators/pulls)

@msherif1234 msherif1234 requested a review from astoycos July 12, 2024 18:08
@msherif1234
Add make catalog-deploy to allow loading opertor to operator hub
f651027 
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
astoycos
astoycos approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@astoycos astoycos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks!

@msherif1234 msherif1234 requested a review from astoycos July 12, 2024 18:14
@astoycos astoycos removed the request for review from anfredette July 12, 2024 18:45
@mergify mergify bot merged commit 5815e34 into bpfman:main Jul 12, 2024
12 checks passed
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this pull request Oct 30, 2024
@openshift-merge-bot
Merge pull request bpfman#43 from openshift/konflux/component-updates…
59a31f8 
…/ocp-bpfman

chore(deps): update ocp-bpfman to 80544f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astoycos astoycos astoycos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OLM / OperatorHub Previews
2 participants
@msherif1234 @astoycos