WIP: Support for Network Namespace Selection in XDP, TC, and TCX Programs #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In support of issue bpfman#410 Signed-off-by: Andre Fredette <afredette@redhat.com>
anfredette
changed the title
msherif1234
reviewed
Mar 6, 2025
| // NamespacePath explicitly specifies a network namespace path (e.g., | ||
| // /proc/<pid>/ns/net or /var/run/netns/<name>) | ||
| // +optional | ||
| NamespacePath *string `json:"namespacePath,omitempty"` |
There was a problem hiding this comment.
why *string as oppose to just string ?
More testing needed. Using an explicit NamespacePath not tested. Also, I'd like to make ClNetworkNamespaceSelector and ClNetworkNamespaceSelector more similar. Signed-off-by: Andre Fredette <afredette@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of issue #410, this proposal introduces optional network namespace selection for XDP, TC, and TCX programs, allowing users to specify where these programs should attach.
Changes:
Cluster-scoped ClusterBpfApplication
/proc/<pid>/ns/netor/var/run/netns/<ns_name>).Namespace-scoped BpfApplication
This approach ensures flexibility for cluster-wide applications while maintaining namespace isolation where required.