Make the bpfman-operator report status of "Pending" instead of "Error" when appropriate #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" when appropriate If any nodes are reporting error, the operator will still report error, however, if there are no errors, but some nodes are in the pending state, the operator will report pending. Fixes: bpfman#399 Signed-off-by: Andre Fredette <afredette@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 31.69% 31.69%
=======================================
Files 66 66
Lines 7794 7800 +6
=======================================
+ Hits 2470 2472 +2
- Misses 5097 5098 +1
- Partials 227 230 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msherif1234
reviewed
Mar 7, 2025
| return rec.updateStatus(ctx, appNamespace, appName, bpfmaniov1alpha1.BpfAppCondError, | ||
| fmt.Sprintf("bpfProgramReconciliation failed on the following BpfApplicationState objects: %v", failedBpfApplications)) | ||
| } else if pendingCount != 0 { | ||
| return rec.updateStatus(ctx, appNamespace, appName, bpfmaniov1alpha1.BpfAppCondPending, "") |
There was a problem hiding this comment.
nit: maybe its useful to show list of pending apps i.e use slice instead of just a counter similar to how to handle the failed app, WDYT ?
msherif1234
reviewed
Mar 7, 2025
| return true | ||
| } else { |
There was a problem hiding this comment.
no need for else here and the same for failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any nodes report an error, the operator will also report an error. However, if there are no errors but some nodes are in a pending state, the operator will report as pending.
Fixes: #399