Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiarch: fix cosign #26

Merged
merged 2 commits into from
Jun 18, 2024
Merged

multiarch: fix cosign #26

merged 2 commits into from
Jun 18, 2024

Conversation

Billy99
Copy link
Contributor

@Billy99 Billy99 commented Jun 17, 2024

PR#24 failed on main because of cosign issues.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.04%. Comparing base (49345cd) to head (5fdfef5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   26.36%   27.04%   +0.67%     
==========================================
  Files          75       75              
  Lines        5112     6083     +971     
==========================================
+ Hits         1348     1645     +297     
- Misses       3600     4274     +674     
  Partials      164      164              
Flag Coverage Δ
unittests 27.04% <ø> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Billy99 Billy99 force-pushed the billy99-fix-cosign branch from 64bb305 to 7220529 Compare June 17, 2024 22:52
@Billy99 Billy99 marked this pull request as ready for review June 17, 2024 22:52
Billy99 and others added 2 commits June 17, 2024 19:14
PR#24 failed on main because of cosign issues.

Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
Copy link
Member

@astoycos astoycos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @Billy99

@mergify mergify bot merged commit f868242 into bpfman:main Jun 18, 2024
15 checks passed
@Billy99 Billy99 deleted the billy99-fix-cosign branch June 18, 2024 11:35
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants