Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make sure BUILDPLATFORM is set in github actions #136

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Billy99
Copy link
Contributor

@Billy99 Billy99 commented Sep 6, 2024

#121 removed the BUILDPLATFORM initialization from the Containerfiles.* (ARG BUILDPLATFORM=linux/amd64 -> ARG BUILDPLATFORM). The bpfman-operator Makefile sets that ARG manually, but it wasn't being set in the github actions. This PR adds BUILDPLATFORM to build-arg parameter passed to the docker github action.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.61%. Comparing base (8af36b9) to head (aa803a3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   27.61%   27.61%           
=======================================
  Files          81       81           
  Lines        6999     6999           
=======================================
  Hits         1933     1933           
  Misses       4877     4877           
  Partials      189      189           
Flag Coverage Δ
unittests 27.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Copy link
Contributor

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 05492e1 into bpfman:main Sep 6, 2024
17 checks passed
@Billy99 Billy99 deleted the billy99-buildplatform branch September 12, 2024 17:01
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this pull request Dec 17, 2024
…s/ocp-bpfman

chore(deps): update ocp-bpfman to 878f25e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants