Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallets providers + layout #7

Merged
merged 2 commits into from
May 4, 2022
Merged

wallets providers + layout #7

merged 2 commits into from
May 4, 2022

Conversation

aspnxdd
Copy link
Contributor

@aspnxdd aspnxdd commented May 4, 2022 •
edited by begonaalvarezd
Loading

This PR includes:

  • All wallets support
  • Basic layout with Navbar
  • 3 emtpy pages for Create CM, List CM
  • HTML form to create CM

Closes #2

@aspnxdd aspnxdd requested review from agus-xyz and begonaalvarezd May 4, 2022 09:47
begonaalvarezd
begonaalvarezd requested changes May 4, 2022
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great 💪🏼
Just left some comments about cleaning the PR to leave only whats relevant

components/CreateCM/Form.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
begonaalvarezd
begonaalvarezd approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@begonaalvarezd begonaalvarezd merged commit 0a4d520 into dev May 4, 2022
@begonaalvarezd begonaalvarezd deleted the feat/wallets-providers branch May 4, 2022 13:07
@begonaalvarezd begonaalvarezd mentioned this pull request May 4, 2022
Closed
@aspnxdd aspnxdd added this to the Candy Machine Dashboard MVP milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@agus-xyz agus-xyz Awaiting requested review from agus-xyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Candy Machine Dashboard MVP
Development

Successfully merging this pull request may close these issues.

[Task]: Add Solana wallet adapters
2 participants
@aspnxdd @begonaalvarezd