Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pr template #55

Merged
merged 1 commit into from
Jun 22, 2022
Merged

feat: add pr template #55

merged 1 commit into from
Jun 22, 2022

Conversation

agus-xyz
Copy link
Member

@agus-xyz agus-xyz commented Jun 22, 2022

Add github repo PR template

@agus-xyz agus-xyz changed the title add pr template feat: add pr template Jun 22, 2022
Comment on lines +1 to +14
Fixes #

## Changes

-

### Checks

* [ ] Have you catchup your branch with the latest state in base?
* [ ] Have you lint your code locally prior to submission?
* [ ] Have you reviewed your proposed changes and removed debris?
* [ ] Have you successfully ran due tests with your changes?


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this template, wdyt?

Suggested change
Fixes #
## Changes
-
### Checks
* [ ] Have you catchup your branch with the latest state in base?
* [ ] Have you lint your code locally prior to submission?
* [ ] Have you reviewed your proposed changes and removed debris?
* [ ] Have you successfully ran due tests with your changes?
## Summary
> Please summarize your changes, describing __what__ they are and __why__ they were made.
...
## Relevant Issues
> Please list any related issues using [development keywords](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword).
...
## Testing Instructions
> Please describe the specific instructions, configurations, and/or test cases necessary to __test and verify__ that your changes work as intended.
...
## Checklist
> Please tick all of the following boxes that are relevant to your changes.
- [ ] I have catchup my branch with the latest state in base.
- [ ] I have linted my code locally prior to submission.
- [ ] I have reviewed my changes and removed debris.
- [ ] I have successfully ran due tests with my changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt a bit too much?

Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@agus-xyz agus-xyz merged commit e02205a into dev Jun 22, 2022
@agus-xyz agus-xyz deleted the feat/github_stuff branch June 22, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants