Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/upload verify button #148

Merged
merged 26 commits into from
Jul 21, 2022
Merged

Feat/upload verify button #148

merged 26 commits into from
Jul 21, 2022

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Jul 20, 2022

Fixes #109

Changes

  • Move verify to popup
  • Verify CM works

Checks

  • Have you catchup your branch with the latest state in base?
  • Have you lint your code locally prior to submission?
  • Have you reviewed your proposed changes and removed debris?
  • Have you successfully ran due tests with your changes?

@cpl121 cpl121 requested review from evavirseda and VmMad July 20, 2022 13:42
@boxfish-bot boxfish-bot temporarily deployed to Preview July 20, 2022 13:42 Inactive
@boxfish-bot boxfish-bot temporarily deployed to Preview July 20, 2022 13:50 Inactive
@cpl121 cpl121 mentioned this pull request Jul 20, 2022
4 tasks
@boxfish-bot boxfish-bot temporarily deployed to Preview July 20, 2022 14:08 Inactive
…xfish-studio/candy-machine-dashboard into feat/upload-verify-button
@boxfish-bot boxfish-bot temporarily deployed to Preview July 20, 2022 14:17 Inactive
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine, just a comment!

)}
{!isVerifying && error && (
<div className={`border color-fg-danger color-bg-danger color-border-danger rounded-2 p-2`}>
<span>{error}</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to hide this error after uploading a file to let the user know the file was uploaded succesfully

@boxfish-bot boxfish-bot temporarily deployed to Preview July 20, 2022 14:36 Inactive
@cpl121 cpl121 requested a review from VmMad July 20, 2022 14:36
@boxfish-bot
Copy link
Member

This pull request has been deployed to Vercel.

Latest commit: 6eeaa0a
✅ Preview: https://candy-machine-dashboard-66nxyhw2v-boxfish-studio.vercel.app
🔍 Inspect: https://vercel.com/boxfish-studio/candy-machine-dashboard/GNhEerZJHgwMxX7JMorBuABgy21B

View Workflow Logs

@agus-xyz agus-xyz merged commit 090d633 into dev Jul 21, 2022
@agus-xyz agus-xyz deleted the feat/upload-verify-button branch July 21, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Upate verify candy machine to new design
5 participants