Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add mint button #143

Merged
merged 5 commits into from
Jul 20, 2022
Merged

Feat: Add mint button #143

merged 5 commits into from
Jul 20, 2022

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Jul 19, 2022

Fixes #105

Changes

  • Update NFT card component to include new mint design and action
  • Mint Nft action

Checks

  • Have you catchup your branch with the latest state in base?
  • Have you lint your code locally prior to submission?
  • Have you reviewed your proposed changes and removed debris?
  • Have you successfully ran due tests with your changes?

@cpl121 cpl121 requested review from evavirseda and VmMad July 19, 2022 10:53
@boxfish-bot boxfish-bot temporarily deployed to Preview July 19, 2022 10:53 Inactive
evavirseda
evavirseda approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@evavirseda evavirseda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀 Conflicts!

VmMad
VmMad requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments

components/NftCard.tsx Outdated Show resolved Hide resolved
components/NftCard.tsx Outdated Show resolved Hide resolved
@cpl121 cpl121 requested a review from VmMad July 20, 2022 08:29
VmMad
VmMad requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments. Let me know what you think

components/NftCard.tsx Outdated Show resolved Hide resolved
components/NftCard.tsx Outdated Show resolved Hide resolved
pages/[id].tsx Show resolved Hide resolved
@cpl121 cpl121 requested a review from VmMad July 20, 2022 11:22
VmMad
VmMad approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me looks good and ready to merge! Just resolve conflicts!

cpl121 added 2 commits July 20, 2022 16:12
@cpl121
Merge branches 'feat/add-mint-1-nft-card' and 'dev' of github.com:box…
5d86e55 
…fish-studio/candy-machine-dashboard into feat/add-mint-1-nft-card
@cpl121
Merge branches 'feat/add-mint-1-nft-card' and 'dev' of github.com:box…
cc52533 
…fish-studio/candy-machine-dashboard into feat/add-mint-1-nft-card
@boxfish-bot boxfish-bot temporarily deployed to Preview July 20, 2022 14:12 Inactive
@boxfish-bot boxfish-bot temporarily deployed to Preview July 20, 2022 14:13 Inactive
@boxfish-bot
Copy link
Member

This pull request has been deployed to Vercel.

Latest commit: cc52533
✅ Preview: https://candy-machine-dashboard-3ti6o33f5-boxfish-studio.vercel.app
🔍 Inspect: https://vercel.com/boxfish-studio/candy-machine-dashboard/Gi9Zg7DYRka3fZjgXAYjbHzVWgGP

View Workflow Logs

@cpl121 cpl121 merged commit 010c773 into dev Jul 20, 2022
@cpl121 cpl121 deleted the feat/add-mint-1-nft-card branch July 20, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

@VmMad VmMad VmMad approved these changes

Assignees
No one assigned
Labels
deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Update mint 1 NFT to new design
4 participants
@cpl121 @boxfish-bot @evavirseda @VmMad