Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update navbar #120

Merged
merged 12 commits into from
Jul 13, 2022
Merged

feat: update navbar #120

merged 12 commits into from
Jul 13, 2022

Conversation

evavirseda
Copy link
Member

Fixes #87

Changes

  • Update the navbar component to use Primer CSS
  • Add Logo and wallet connection

Checks

  • Have you catchup your branch with the latest state in base?
  • Have you lint your code locally prior to submission?
  • Have you reviewed your proposed changes and removed debris?
  • Have you successfully ran due tests with your changes?

@evavirseda evavirseda requested a review from cpl121 July 11, 2022 13:51
@boxfish-bot boxfish-bot temporarily deployed to Preview July 11, 2022 13:51 Inactive
@evavirseda evavirseda requested a review from VmMad July 11, 2022 13:52
@evavirseda
Copy link
Member Author

The previous design also included tooltips for navbar items, but it may not be necessary now, what do you think? @VmMad @cpl121

@boxfish-bot boxfish-bot temporarily deployed to Preview July 12, 2022 09:35 Inactive
@VmMad
Copy link
Member

VmMad commented Jul 12, 2022

Yeah I don't think any tooltips are necessary here. The ones in the PR right now are kinda redundant

@boxfish-bot boxfish-bot temporarily deployed to Preview July 12, 2022 11:14 Inactive
@evavirseda evavirseda changed the title Feat/update navbar feat: update navbar Jul 12, 2022
VmMad
VmMad reviewed Jul 12, 2022
View reviewed changes
components/Navbar.tsx Outdated Show resolved Hide resolved
components/Navbar.tsx Outdated Show resolved Hide resolved
components/Navbar.tsx Show resolved Hide resolved
@boxfish-bot boxfish-bot temporarily deployed to Preview July 12, 2022 13:33 Inactive
VmMad
VmMad approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

cpl121
cpl121 reviewed Jul 13, 2022
View reviewed changes
components/Navbar.tsx Outdated Show resolved Hide resolved
cpl121
cpl121 reviewed Jul 13, 2022
View reviewed changes
components/Navbar.tsx Outdated Show resolved Hide resolved
@boxfish-bot boxfish-bot temporarily deployed to Preview July 13, 2022 08:17 Inactive
@boxfish-bot boxfish-bot temporarily deployed to Preview July 13, 2022 08:23 Inactive
@boxfish-bot
Copy link
Member

This pull request has been deployed to Vercel.

Latest commit: d2adc83
✅ Preview: https://candy-machine-dashboard-c3rbegzmf-boxfish-studio.vercel.app
🔍 Inspect: https://vercel.com/boxfish-studio/candy-machine-dashboard/5ZCfWHhcHL7wibamE2hg1x3hDo9F

View Workflow Logs

cpl121
cpl121 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@evavirseda evavirseda merged commit 186604a into dev Jul 13, 2022
@evavirseda evavirseda deleted the feat/update-navbar branch July 13, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@VmMad VmMad VmMad approved these changes

Assignees
No one assigned
Labels
deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Update navbar to new design system
4 participants
@evavirseda @VmMad @boxfish-bot @cpl121