who doesn't enjoy a rewrite #83
Conversation
| ## Breakages since last major version | ||
|
|
||
| * `ruby::global` does not work with chruby | ||
| * bundler is no longer installed by default in rubies |
There was a problem hiding this comment.
Is this true? It is not what https://github.com/boxen/puppet-ruby/pull/83/files#diff-f262dd5a1d44eba22201543fc69550bcR69 is doing?
There was a problem hiding this comment.
It was true when the README was last updated 😉
I'm working on some dirty hacks to make these "in-every-ruby" sort of gems not require hardcoding in the ruby::version class.
|
@dgoodlad the hiera-related spec failures here are super weird and hard to debug. Please look into them when you've got a chance. |
|
@wfarr god. this again. It'll be a missing symlink. or something. Basically the module-data hiera stuff isn't loading at all in the specs. Trying to figure out wtf it's up to |
|
The build is finally green on this branch! Major changes since @wfarr originally opened this PR are
@wfarr @rafaelfranca I think it's time to give this PR another once-over |
| provider => 'shell', | ||
| cwd => "~/src/project", | ||
| require => [ Ruby::Gem["bundler for ${version}"], Package['zsh'] ] | ||
| exec { '/opt/rubies/2.1.0/bin/bundle install': |
There was a problem hiding this comment.
Does this even work? I would've expected the bundler environment to ruin everything (e.g. BUNDLER_GEMFILE). We might want to offer a custom gem_exec type?
There was a problem hiding this comment.
I'm more of the mind that doing this sort of thing is a smell than anything, but if that floats your boat, gem_exec seems fine.
There was a problem hiding this comment.
Yeah me too; we'll leave it alone unless we need it.
…and-chruby-sittin-in-a-tree Conflicts: lib/puppet/provider/rbenv_gem/rubygems.rb manifests/params.pp spec/classes/ruby_spec.rb
| # Class: ruby::gems | ||
| # | ||
| # (INTERNAL) Installs global ruby gems | ||
| class ruby::gems { |
There was a problem hiding this comment.
I don't think we should ship this as a default things for folks.
For better or worse, some folks really dislike Bundler (or name any gem really) and we're going to get the inevitable "why are you forcing this on me?"
I'd much rather just document this really well in the README as the way to handle this sort of thing.
This then gives us the option to if we want, provide modules for gem management: puppet-bundler, etc.
... and document how to do it
Rewrite with support for both rbenv and chruby
|
🎉 |
Well, partial rewrite.
Big feature out of this one is support for chruby and rbenv, toggle-able via Hiera.
So not ready to merge yet, and still has a few bugs here and there (and everywhere).