This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
remove relative node_modules .bin from PATH #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't it already configurable in the sense that the user can add it to his or her PATH if they choose to? |
|
@msuess I think you are right... It also makes difficult the use of globally installed packages. what do you think @DanielWright??? I merged your PR, and I would love to hear you thoughts... |
|
I agree with @msuess. I was wrong to readd the old behaviour in my PR; it's unexpected and difficult to disable. |
|
@blackjid Could you tag a new release? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having './node_modules/.bin' on the PATH breaks react-native and causes other NPM modules to be confused as to where they are installed (ie. phantomjs). Maybe it's best to leave this decision to the user instead of having it as default. This is not really boxen-specific behaviour anyway and is not needed to run nodejs via boxen.