Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Configurable hub.protocol value #8

Merged
merged 2 commits into from
Jan 7, 2014
Merged

Conversation

dgoodlad
Copy link
Contributor

@dgoodlad dgoodlad commented Jan 7, 2014

This change makes the global git config hub.protocol configurable with hiera. The value still defaults to https, but can be overridden by setting hub::protocol: git in hiera data.

I prefer this over #7 - @fromonesrc thoughts?

@ocxo
Copy link
Contributor

ocxo commented Jan 7, 2014

👍

@ocxo ocxo mentioned this pull request Jan 7, 2014
dgoodlad added a commit that referenced this pull request Jan 7, 2014
Configurable hub.protocol value
@dgoodlad dgoodlad merged commit 0f6ee61 into master Jan 7, 2014
@dgoodlad dgoodlad deleted the configurable-protocol branch January 7, 2014 03:23
@dgoodlad
Copy link
Contributor Author

dgoodlad commented Jan 7, 2014

Released in 1.3.0

@blackjid
Copy link
Member

Hi @dgoodlad !, i'm trying to change the default protocol to ssh but is not working

I'm adding to my ~/src/our-boxen/config/hiera.yaml this

---
:hub:
  :protocol: ssh

But nothing happend. My .gitconfig already has protocol = https that was added by this puppet module, but it doesn't change. Any idea? thanks!

For reference this is our-boxen repo

@dgoodlad
Copy link
Contributor Author

@blackjid that's close 😄 config/hiera.yml only configures hiera, it's not a data source. You probably want something like this:

config/hiera.yaml:

---
:backends:
  - yaml
:yaml:
  :datadir: "%{::boxen_home}/repo/hiera"
:hierarchy:
  - "users/%{github_login}"
  - common

and then make a directory called hiera, with hiera/common.yaml containing:

---
hub::protocol: ssh

I've got a local branch of the sample our-boxen repo that I've been working on the past couple of days which adds examples and documentation for this and a few other things. Go ahead and give this a try, or hold on for a few days and I'll have the docs finished!

@blackjid
Copy link
Member

Thanks!, I couldn't wait :) It worked like charm...
Probably I will have merging conflicts when I update from upstream, but... it's ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants