Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Drop support for python 3.5 #654

Merged
merged 1 commit into from
Jan 5, 2022
Merged

feat!: Drop support for python 3.5 #654

merged 1 commit into from
Jan 5, 2022

Conversation

lukaszsocha2
Copy link
Contributor

Closes: SDK-1889

@coveralls
Copy link

coveralls commented Jan 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2778

  • 71 of 83 (85.54%) changed or added relevant lines in 21 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 93.671%
Changes Missing Coverage Covered Lines Changed/Added Lines %
boxsdk/auth/oauth2.py 4 5 80.0%
boxsdk/network/default_network.py 2 3 66.67%
boxsdk/session/box_response.py 0 1 0.0%
boxsdk/exception.py 17 19 89.47%
boxsdk/object/base_api_json_object.py 2 4 50.0%
boxsdk/object/base_object.py 2 4 50.0%
boxsdk/object/search.py 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
boxsdk/object/base_api_json_object.py 1 91.84%
Totals Coverage Status
Change from base Build 2775: -0.02%
Covered Lines: 3241
Relevant Lines: 3460
💛 - Coveralls

antusus
antusus approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukaszsocha2 lukaszsocha2 merged commit 2208047 into main Jan 5, 2022
@lukaszsocha2 lukaszsocha2 deleted the sdk-1889-drop-python-3.5 branch January 5, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antusus antusus antusus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszsocha2 @coveralls @antusus