fix: missing api_call decorators on multiput calls #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveSawyer
changed the title
DaveSawyer
changed the title
Pull Request Test Coverage Report for Build 2783
💛 - Coveralls |
lukaszsocha2
reviewed
Jan 5, 2022
boxsdk/object/upload_session.py
Outdated
| @@ -18,6 +19,7 @@ class UploadSession(BaseObject): | |||
| _item_type = 'upload_session' | |||
| _parent_item_type = 'file' | |||
|
|
|||
| @api_call | |||
There was a problem hiding this comment.
Is there any reason for adding api_call decorator to get_url() method? In other places we didn't put this decorator on this method
There was a problem hiding this comment.
looks like this doesn't result in a network call so I removed it.
|
Generally looks ok, but left one question |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows callers to pass extra_network_parameters. Issue #655