Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support base item operations for WebLink #639

Merged
merged 2 commits into from
Dec 8, 2021
Merged

feat: Support base item operations for WebLink #639

merged 2 commits into from
Dec 8, 2021

Conversation

lukaszsocha2
Copy link
Contributor

Closes: SDK-1862

@lukaszsocha2 lukaszsocha2 force-pushed the sdk-1862-support-shared-links-for-web_link branch from 2d07577 to 968ee92 Compare December 2, 2021 16:27
@coveralls
Copy link

coveralls commented Dec 2, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 2736

  • 84 of 84 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.774%
Totals Coverage Status
Change from base Build 2733: 0.03%
Covered Lines: 3210
Relevant Lines: 3317
💛 - Coveralls

@lukaszsocha2 lukaszsocha2 force-pushed the sdk-1862-support-shared-links-for-web_link branch from f775258 to 2565bd5 Compare December 3, 2021 14:43
@lukaszsocha2
Copy link
Contributor Author

Items new class structure is presented on this diagram:
image

@lukaszsocha2 lukaszsocha2 force-pushed the sdk-1862-support-shared-links-for-web_link branch 2 times, most recently from 5e3448f to d86f0fa Compare December 3, 2021 15:15
antusus
antusus reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like all the changes, but after merging this we will have new documentation for things that were not released yet. Are we planning to do a release soon? Or maybe we should move the documentation changes to separate branch and merge it before release?

@lukaszsocha2
Copy link
Contributor Author

The plan was to make a release right after merging this, but now with failing python 2.7 build I think we have to fix it or drop python 2.7 first.

@lukaszsocha2 lukaszsocha2 force-pushed the sdk-1862-support-shared-links-for-web_link branch 3 times, most recently from 59afae2 to e582281 Compare December 7, 2021 16:01
@lukaszsocha2 lukaszsocha2 force-pushed the sdk-1862-support-shared-links-for-web_link branch from e582281 to 6c16088 Compare December 8, 2021 11:14
@lukaszsocha2 lukaszsocha2 merged commit a19071d into main Dec 8, 2021
@lukaszsocha2 lukaszsocha2 deleted the sdk-1862-support-shared-links-for-web_link branch December 8, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antusus antusus antusus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszsocha2 @coveralls @antusus