Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download ZIP retry loop #844

Closed
4 tasks done
psevertson opened this issue Sep 12, 2023 · 1 comment · Fixed by #845
Closed
4 tasks done

Download ZIP retry loop #844

psevertson opened this issue Sep 12, 2023 · 1 comment · Fixed by #845
Assignees
Labels

Comments

@psevertson
Copy link

  • I have checked that the [SDK documentation][sdk-docs] doesn't solve my issue.
  • I have checked that the [API documentation][api-docs] doesn't solve my issue.
  • I have searched the [Box Developer Forums][dev-forums] and my issue isn't already reported (or if it has been reported, I have attached a link to it, for reference).
  • I have searched [Issues in this repo][github-repo] and my issue isn't already reported.

Description of the Issue

The download_zip call is missing the skip_retry_codes={202} parameter, which is causing it to retry MAX_RETRY_ATTEMPTS times until it returns the successful response

Steps to Reproduce

  1. Call client.download_zip() with a zip name, files to zip, and a writeable stream
  2. The download takes a long time to generate, because it gets stuck in a retry loop

Expected Behavior

Expected the zip download to complete in a quicker time by returning the first successful response

Versions Used

Python SDK: 3.9.0
Python: 3.9.13

@antusus
Copy link
Contributor

antusus commented Sep 13, 2023

Hi @psevertson,

thanks for pointing that out. We are working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants