Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iterator support for group collaborations #813

Merged
merged 14 commits into from
Jun 5, 2020

Conversation

sujaygarlanka
Copy link
Contributor

Goal of this PR is to add iterator support for file, folder, and group collaborations.

  • Already there for file collaborations
  • Folder collaborations don't support pagination, so iterator support can't be added
  • Added for group collaborations

@coveralls
Copy link

coveralls commented May 28, 2020

Pull Request Test Coverage Report for Build 2244

  • 15 of 18 (83.33%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 65.948%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxGroup.java 7 8 87.5%
src/main/java/com/box/sdk/BoxCollaborationIterator.java 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/EventStream.java 1 87.63%
src/main/java/com/box/sdk/BoxJSONResponse.java 2 93.33%
src/main/java/com/box/sdk/RealtimeServerConnection.java 3 80.0%
Totals Coverage Status
Change from base Build 2228: -0.01%
Covered Lines: 5601
Relevant Lines: 8493

💛 - Coveralls

@sujaygarlanka sujaygarlanka changed the title Add iterator support group collaborations Add iterator support for group collaborations May 28, 2020
doc/groups.md Outdated Show resolved Hide resolved
doc/groups.md Outdated Show resolved Hide resolved
src/main/java/com/box/sdk/BoxCollaborationIterator.java Outdated Show resolved Hide resolved
doc/groups.md Outdated Show resolved Hide resolved
doc/groups.md Outdated Show resolved Hide resolved
doc/groups.md Outdated Show resolved Hide resolved
doc/groups.md Outdated Show resolved Hide resolved
doc/groups.md Outdated Show resolved Hide resolved
src/main/java/com/box/sdk/BoxCollectionIterator.java Outdated Show resolved Hide resolved
sujaygarlanka and others added 10 commits June 4, 2020 18:27
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
@sujaygarlanka sujaygarlanka merged commit fb0d552 into master Jun 5, 2020
@sujaygarlanka sujaygarlanka deleted the iterator-for-collaborations branch June 5, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants