Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double for metadata numbers #811

Merged
merged 6 commits into from
Jun 5, 2020

Conversation

PJSimon
Copy link
Contributor

@PJSimon PJSimon commented May 27, 2020

Box JAVA SDK uses float to set value in metadata. Metadata uses number as field type. Metadata can handle values with higher precision as compared to JAVA float e.g. setting 233333333333333340 in number field returns 2333333341.

@coveralls
Copy link

coveralls commented May 27, 2020

Pull Request Test Coverage Report for Build 2250

  • 11 of 16 (68.75%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 65.946%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/Metadata.java 9 14 64.29%
Totals Coverage Status
Change from base Build 2249: -0.003%
Covered Lines: 5610
Relevant Lines: 8507

💛 - Coveralls

@PJSimon
Copy link
Contributor Author

PJSimon commented Jun 5, 2020

Connection to Travis appears to have broken, but the last build passed: https://travis-ci.org/github/box/box-java-sdk/builds/695072611
Doing Admin Squash and Merge ...

@PJSimon PJSimon merged commit 572aaf0 into master Jun 5, 2020
@PJSimon PJSimon deleted the SDK-1404-use-double-for-metadata-numbers branch June 5, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants