Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path parameter sanitization #797

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Fix path parameter sanitization #797

merged 2 commits into from
Apr 23, 2020

Conversation

sujaygarlanka
Copy link
Contributor

The SDK did not break execution and throw an exception to the user and when the sanitization check for parameters failed. This is now fixed.

@coveralls
Copy link

coveralls commented Apr 23, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2186

  • 2 of 8 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 65.623%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/URLTemplate.java 2 8 25.0%
Totals Coverage Status
Change from base Build 2184: -0.004%
Covered Lines: 5532
Relevant Lines: 8430
💛 - Coveralls

@PJSimon PJSimon merged commit 67f068c into master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJSimon PJSimon PJSimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sujaygarlanka @coveralls @PJSimon