Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds shared link downscoping and coverage #785

Merged
merged 11 commits into from
Jun 15, 2020

Conversation

boxdave
Copy link
Collaborator

@boxdave boxdave commented Mar 23, 2020

  • Adds string sharedLink arg thats a Box shared link to BoxAPIConnection.getLowerScopedToken. Returns a downscoped token for the resource associated to the shared link if the args not null.
  • Adds test coverage.

src/main/java/com/box/sdk/BoxAPIConnection.java Outdated Show resolved Hide resolved
src/test/java/com/box/sdk/BoxAPIConnectionTest.java Outdated Show resolved Hide resolved
src/test/java/com/box/sdk/BoxAPIConnectionTest.java Outdated Show resolved Hide resolved
src/test/java/com/box/sdk/BoxAPIConnectionTest.java Outdated Show resolved Hide resolved
src/main/java/com/box/sdk/BoxAPIConnection.java Outdated Show resolved Hide resolved
src/main/java/com/box/sdk/BoxAPIConnection.java Outdated Show resolved Hide resolved
src/main/java/com/box/sdk/BoxAPIConnection.java Outdated Show resolved Hide resolved
src/main/java/com/box/sdk/BoxAPIConnection.java Outdated Show resolved Hide resolved
src/main/java/com/box/sdk/BoxAPIConnection.java Outdated Show resolved Hide resolved
src/main/java/com/box/sdk/BoxAPIConnection.java Outdated Show resolved Hide resolved
src/main/java/com/box/sdk/BoxAPIConnection.java Outdated Show resolved Hide resolved
src/test/java/com/box/sdk/BoxAPIConnectionTest.java Outdated Show resolved Hide resolved
@PJSimon
Copy link
Contributor

PJSimon commented Apr 30, 2020

@boxdave I think the comments from Cary can be resolved, right?

@coveralls
Copy link

coveralls commented Jun 13, 2020

Pull Request Test Coverage Report for Build 2257

  • 24 of 42 (57.14%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 65.933%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxAPIConnection.java 24 42 57.14%
Totals Coverage Status
Change from base Build 2253: -0.05%
Covered Lines: 5630
Relevant Lines: 8539

💛 - Coveralls

carycheng
carycheng previously approved these changes Jun 15, 2020
sujaygarlanka
sujaygarlanka previously approved these changes Jun 15, 2020
@PJSimon PJSimon dismissed stale reviews from sujaygarlanka and carycheng via 2a2f0d4 June 15, 2020 18:13
@PJSimon PJSimon merged commit 1d907c1 into master Jun 15, 2020
@PJSimon PJSimon deleted the feature/shared-link-downscoping branch June 15, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants