-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds shared link downscoping and coverage #785
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
boxdave
commented
Mar 23, 2020
- Adds string sharedLink arg thats a Box shared link to BoxAPIConnection.getLowerScopedToken. Returns a downscoped token for the resource associated to the shared link if the args not null.
- Adds test coverage.
carycheng
approved these changes
Mar 23, 2020
carycheng
suggested changes
Mar 23, 2020
PJSimon
reviewed
Apr 30, 2020
@boxdave I think the comments from Cary can be resolved, right? |
Pull Request Test Coverage Report for Build 2257
💛 - Coveralls |
carycheng
previously approved these changes
Jun 15, 2020
sujaygarlanka
previously approved these changes
Jun 15, 2020
sujaygarlanka
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.