Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Set Metadata #697

Merged
merged 3 commits into from
Apr 23, 2019
Merged

Support for Set Metadata #697

merged 3 commits into from
Apr 23, 2019

Conversation

carycheng
Copy link

No description provided.

@boxcla
Copy link

boxcla commented Apr 22, 2019

Hi @carycheng, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@coveralls
Copy link

coveralls commented Apr 22, 2019

Pull Request Test Coverage Report for Build 1878

  • 41 of 45 (91.11%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 62.512%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxFile.java 20 22 90.91%
src/main/java/com/box/sdk/BoxFolder.java 20 22 90.91%
Totals Coverage Status
Change from base Build 1875: 0.4%
Covered Lines: 5041
Relevant Lines: 8064

💛 - Coveralls

Copy link

@mattwiller mattwiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor documentation comments, but the implementation looks good to me!

doc/files.md Outdated Show resolved Hide resolved
src/main/java/com/box/sdk/BoxFile.java Outdated Show resolved Hide resolved
@carycheng carycheng merged commit e4e4653 into master Apr 23, 2019
@carycheng carycheng deleted the set_metadata branch April 23, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants