Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sorting folder items #694

Merged
merged 9 commits into from
Apr 9, 2019
Merged

Add support for sorting folder items #694

merged 9 commits into from
Apr 9, 2019

Conversation

carycheng
Copy link

No description provided.

@boxcla
Copy link

boxcla commented Apr 8, 2019

Hi @carycheng, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1866

  • 11 of 12 (91.67%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.006%) to 62.09%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxFolder.java 11 12 91.67%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/EventStream.java 1 87.5%
src/main/java/com/box/sdk/RealtimeServerConnection.java 3 80.0%
Totals Coverage Status
Change from base Build 1863: -0.006%
Covered Lines: 4979
Relevant Lines: 8019

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 8, 2019

Pull Request Test Coverage Report for Build 1869

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.007%) to 62.103%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/EventStream.java 1 87.5%
src/main/java/com/box/sdk/RealtimeServerConnection.java 3 80.0%
Totals Coverage Status
Change from base Build 1863: 0.007%
Covered Lines: 4980
Relevant Lines: 8019

💛 - Coveralls

doc/folders.md Outdated Show resolved Hide resolved
src/test/java/com/box/sdk/BoxFolderTest.java Outdated Show resolved Hide resolved
src/test/java/com/box/sdk/BoxFolderTest.java Outdated Show resolved Hide resolved
@carycheng carycheng merged commit 08d9571 into master Apr 9, 2019
@carycheng carycheng deleted the folder_items_sort branch April 9, 2019 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants