Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort and direction fields to search #689

Merged
merged 6 commits into from
Mar 29, 2019
Merged

Add sort and direction fields to search #689

merged 6 commits into from
Mar 29, 2019

Conversation

carycheng
Copy link

No description provided.

@boxcla
Copy link

boxcla commented Mar 29, 2019

Hi @carycheng, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1837

  • 8 of 12 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 61.373%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxSearchParameters.java 8 12 66.67%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/BoxSearchParameters.java 1 68.6%
Totals Coverage Status
Change from base Build 1835: 0.07%
Covered Lines: 4908
Relevant Lines: 7997

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 29, 2019

Pull Request Test Coverage Report for Build 1840

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 61.536%

Totals Coverage Status
Change from base Build 1835: 0.2%
Covered Lines: 4921
Relevant Lines: 7997

💛 - Coveralls

@carycheng carycheng merged commit a253606 into master Mar 29, 2019
@carycheng carycheng deleted the search-query branch March 29, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants