Add option to pass file SHA-1 hash for upload integrity #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a sha1 attribute to FileUploadParams to enable sending the expected hash of the file for verification that the file was not corrupted in transit. Fixes #328
|
Verified that @mattwiller has signed the CLA. Thanks for the pull request! |
iamharish
reviewed
Dec 21, 2017
| @@ -493,6 +493,10 @@ public void canUpload(String name, long fileSize) { | |||
| fieldJSON.add("content_modified_at", BoxDateFormat.format(uploadParams.getModified())); | |||
| } | |||
|
|
|||
| if (uploadParams.getSHA1() != null) { | |||
There was a problem hiding this comment.
Better to check that string is not empty
uploadParams.getSHA1() != null && !uploadParams.getSHA1().isEmpty()
iamharish
reviewed
Dec 21, 2017
iamharish
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a sha1 attribute to FileUploadParams to enable sending the
expected hash of the file for verification that the file was not
corrupted in transit.
Fixes #328