Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-app scripting vulnerability #440

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Fix cross-app scripting vulnerability #440

merged 2 commits into from
Apr 7, 2021

Conversation

swfree
Copy link
Contributor

@swfree swfree commented Apr 6, 2021

Issue Link 🔗

Goals ⚽

  • Fix cross-app scripting vulnerability in OAuthActivity

Implementation Details 🚧

  • Google Play Store's recommends an option to fix this security vulnerability, which is to not export the affected WebView Activity (OAuthActivity). See here for more details on the recommendations: https://support.google.com/faqs/answer/9084685?hl=en-GB
  • Here is the original change where OAuthActivity was initially exported. The intention of the original fix was to prevent OAuthActivity from being recreated upon screen reorientation. This fix is achieved with the addition of android:configChanges="orientation|screenSize", whereas exporting the activity is not required.

Testing Details 🔍

  • Verified that OAuthActivity is not being recreated upon screen rotation
  • Ran tests

@swfree swfree merged commit 8730369 into master Apr 7, 2021
@swfree swfree deleted the xss-security-fix branch April 7, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants