Add path parameter sanitization #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJSimon
previously approved these changes
Jun 24, 2020
sujaygarlanka
force-pushed
the
path-sanitization
branch
from
c362890
to
a5eb2da
Compare
PJSimon
previously approved these changes
Jun 25, 2020
sujaygarlanka
changed the title
PJSimon
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added path parameter sanitization so no relative paths can be passed (i.e.
/../). I did not include this logic inbuildURL()inBoxRequestbecause though this is used for most requests, it is not the onlybuildURL()method. There are others in the SDK that are used for other requests. So I would have to include the logic in multiple methods if I chose thebuildURL()route. The only method all requests used was thesend()method inBoxRequest, so I included the sanitization logic here.